Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issue 2104233003: Fix and tests command line options (Closed)

Created:
4 years, 5 months ago by Johnni Winther
Modified:
4 years, 5 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix and tests command line options Initial test of regression on the --resolve-only vs --resolution-inputs options. R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/bbd2d67481d9a79809cc0a0a94a8f1391795d7d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -2 lines) Patch
M pkg/compiler/lib/src/dart2js.dart View 2 chunks +3 lines, -2 lines 0 comments Download
A tests/compiler/dart2js/command_line_test.dart View 1 chunk +80 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years, 5 months ago (2016-06-29 13:24:52 UTC) #2
Harry Terkelsen
lgtm
4 years, 5 months ago (2016-06-30 16:48:39 UTC) #3
Johnni Winther
4 years, 5 months ago (2016-07-01 08:33:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bbd2d67481d9a79809cc0a0a94a8f1391795d7d5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698