Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2104223003: SkPDF: always assume SkStreamAsset behaves as specified (Closed)

Created:
4 years, 5 months ago by hal.canary
Modified:
4 years, 5 months ago
Reviewers:
Tom Hudson, tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: always assume SkStreamAsset behaves as specified GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2104223003 Committed: https://skia.googlesource.com/skia/+/2633e62f7798a17f095ba1f27ec1f72e5472c439

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -23 lines) Patch
M src/pdf/SkPDFStream.cpp View 1 chunk +13 lines, -23 lines 1 comment Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104223003/1
4 years, 5 months ago (2016-06-29 13:34:36 UTC) #5
hal.canary
ptal
4 years, 5 months ago (2016-06-29 13:35:06 UTC) #7
Tom Hudson
https://codereview.chromium.org/2104223003/diff/1/src/pdf/SkPDFStream.cpp File src/pdf/SkPDFStream.cpp (right): https://codereview.chromium.org/2104223003/diff/1/src/pdf/SkPDFStream.cpp#newcode46 src/pdf/SkPDFStream.cpp:46: SkASSERT(stream->hasLength()); I thought you were getting rid of these?
4 years, 5 months ago (2016-06-29 13:37:28 UTC) #9
hal.canary
On 2016/06/29 13:37:28, Tom Hudson wrote: > https://codereview.chromium.org/2104223003/diff/1/src/pdf/SkPDFStream.cpp > File src/pdf/SkPDFStream.cpp (right): > > https://codereview.chromium.org/2104223003/diff/1/src/pdf/SkPDFStream.cpp#newcode46 ...
4 years, 5 months ago (2016-06-29 13:39:51 UTC) #10
Tom Hudson
lgtm
4 years, 5 months ago (2016-06-29 14:18:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104223003/1
4 years, 5 months ago (2016-06-29 14:22:52 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 14:23:51 UTC) #15
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2633e62f7798a17f095ba1f27ec1f72e5472c439

Powered by Google App Engine
This is Rietveld 408576698