Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2104223002: Flip Google Chrome Mac, mac trunk to GN for testing. (Closed)

Created:
4 years, 5 months ago by Dirk Pranke
Modified:
4 years, 5 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flip Google Chrome Mac, mac trunk to GN for testing. I will revert this CL once we have a build or two for data. R=rsesek@chromium.org BUG=622406 Committed: https://crrev.com/dde87e139b67dcdd6dcb598b35f56aca2314bd47 Cr-Commit-Position: refs/heads/master@{#402662}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/mb/mb_config.pyl View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Dirk Pranke
4 years, 5 months ago (2016-06-28 23:46:52 UTC) #1
Robert Sesek
LGTM thanks!
4 years, 5 months ago (2016-06-28 23:47:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104223002/1
4 years, 5 months ago (2016-06-28 23:48:56 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 02:17:45 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/dde87e139b67dcdd6dcb598b35f56aca2314bd47 Cr-Commit-Position: refs/heads/master@{#402662}
4 years, 5 months ago (2016-06-29 02:19:55 UTC) #7
Dirk Pranke
4 years, 5 months ago (2016-06-29 04:36:58 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2110723002/ by dpranke@chromium.org.

The reason for reverting is: The remoting_me2me_host fix hasn't landed, and so
the compile fails before we really get to test the dump_syms fix. 

I'll try again tomorrow ....

Powered by Google App Engine
This is Rietveld 408576698