Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 2104213002: Added observatory_ui tests to configuration (Closed)

Created:
4 years, 5 months ago by cbernaschina
Modified:
4 years, 5 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Added observatory_ui tests to configuration #

Patch Set 3 : Fixed copyright notice #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
A + runtime/observatory/tests/observatory_ui/observatory_ui.status View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M tools/testing/dart/test_configurations.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tools/testing/dart/test_options.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
cbernaschina
4 years, 5 months ago (2016-06-28 23:34:51 UTC) #2
Cutch
lgtm
4 years, 5 months ago (2016-06-29 13:44:04 UTC) #3
cbernaschina
4 years, 5 months ago (2016-06-29 15:39:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
412c5f7bf590fa3e5ffca783f127c091bbc5fa71 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698