Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2104203003: GN: chromeos: Add missing components tests (Closed)

Created:
4 years, 5 months ago by stevenjb
Modified:
4 years, 5 months ago
CC:
chirantan+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: chromeos: Add missing components tests BUG=504084 Committed: https://crrev.com/f854323abcf7453e80982fee451eafb1cc200ed8 Cr-Commit-Position: refs/heads/master@{#403202}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M components/BUILD.gn View 1 2 chunks +5 lines, -0 lines 0 comments Download
M components/policy/core/common/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download
M components/timers/BUILD.gn View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (9 generated)
stevenjb
These tests were missing from linux chromeos GN builds.
4 years, 5 months ago (2016-06-28 22:37:28 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104203003/1
4 years, 5 months ago (2016-06-28 22:40:21 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/88670) android_clang_dbg_recipe on ...
4 years, 5 months ago (2016-06-28 22:50:20 UTC) #6
Dirk Pranke
lgtm
4 years, 5 months ago (2016-06-29 01:22:52 UTC) #7
jochen (gone - plz use gerrit)
seems like you put some chromeos targets into non-chromeos builds
4 years, 5 months ago (2016-06-29 15:21:56 UTC) #8
stevenjb
On 2016/06/29 15:21:56, jochen wrote: > seems like you put some chromeos targets into non-chromeos ...
4 years, 5 months ago (2016-06-29 19:53:27 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104203003/20001
4 years, 5 months ago (2016-06-29 19:56:38 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-29 21:27:57 UTC) #13
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-06-30 15:14:49 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104203003/20001
4 years, 5 months ago (2016-06-30 17:04:18 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-30 17:09:10 UTC) #19
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 17:09:12 UTC) #20
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 17:11:47 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f854323abcf7453e80982fee451eafb1cc200ed8
Cr-Commit-Position: refs/heads/master@{#403202}

Powered by Google App Engine
This is Rietveld 408576698