chrome/browser/autocomplete/search_provider.h - Issue 21042013: Have SearchProvider look up the omnibox start margin directly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/search_provider.h

Issue 21042013: Have SearchProvider look up the omnibox start margin directly. (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Respond to comments. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/autocomplete/search_provider.h

diff --git a/chrome/browser/autocomplete/search_provider.h b/chrome/browser/autocomplete/search_provider.h

index 74c5e7eba53c808efd636760cbcfdcd555843b67..5f25f3552deae77d7e552f75660079e01f08a1ee 100644

--- a/chrome/browser/autocomplete/search_provider.h

+++ b/chrome/browser/autocomplete/search_provider.h

@@ -94,9 +94,6 @@ class SearchProvider : public AutocompleteProvider,

virtual void AddProviderInfo(ProvidersInfo* provider_info) const OVERRIDE;

virtual void ResetSession() OVERRIDE;

- // Update the omnibox start margin used to generate search suggestion URLs.

- void SetOmniboxStartMargin(int omnibox_start_margin);

bool field_trial_triggered_in_session() const {

return field_trial_triggered_in_session_;

}

@@ -527,9 +524,6 @@ class SearchProvider : public AutocompleteProvider,

// session.

bool field_trial_triggered_in_session_;

- // Start margin of the omnibox. Used to construct search URLs.

- int omnibox_start_margin_;

// If true, search history query suggestions will score low enough that

// they will not be inlined.

bool prevent_search_history_inlining_;

« no previous file with comments | « no previous file | chrome/browser/autocomplete/search_provider.cc » ('j') | chrome/browser/autocomplete/search_provider.cc » ('J')