Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 2104183002: Rationalize mojo_public_*tests targets. (Closed)

Created:
4 years, 5 months ago by viettrungluu
Modified:
4 years, 5 months ago
Reviewers:
jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Rationalize mojo_public_*tests targets. * All the C++ tests become mojo_public_cpp_*_{unit,perf}tests. * All the C tests become mojo_public_c_*_{unit,perf}tests. * mojo_public_system_unittests previously contained both C and C++ tests; split it into two. * Rename some of the C++ tests previously in mojo_public_system_unittests (they had "Cpp" in their name, to avoid colliding with C tests). * Remove an unnecessary dependency of mojo_public_c_system_perftests on mojo/public/cpp/system/macros.h. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/de6c20aad64d53a7061c10e724e9924cfec679f6

Patch Set 1 #

Patch Set 2 : moar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -60 lines) Patch
M mojo/BUILD.gn View 1 chunk +44 lines, -25 lines 0 comments Download
M mojo/public/c/system/tests/BUILD.gn View 2 chunks +1 line, -4 lines 0 comments Download
M mojo/public/c/system/tests/message_pipe_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/c/system/tests/perftest_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/c/system/tests/wait_set_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/system/tests/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M mojo/public/cpp/system/tests/core_unittest.cc View 7 chunks +8 lines, -9 lines 0 comments Download
M mojo/public/cpp/system/tests/macros_unittest.cc View 6 chunks +5 lines, -7 lines 0 comments Download
M mojo/tools/data/unittests View 1 chunk +12 lines, -6 lines 0 comments Download
M mojo/tools/get_test_list.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
viettrungluu
4 years, 5 months ago (2016-06-28 22:16:52 UTC) #1
viettrungluu
Don't mind the patch failures (mirror doesn't have the __native_client__ patch yet, I think).
4 years, 5 months ago (2016-06-28 22:19:36 UTC) #2
jamesr
On 2016/06/28 at 22:19:36, viettrungluu wrote: > Don't mind the patch failures (mirror doesn't have ...
4 years, 5 months ago (2016-06-28 22:32:49 UTC) #3
jamesr
Looks like those errors are fading out. lgtm assuming it clears up
4 years, 5 months ago (2016-06-28 22:33:49 UTC) #4
viettrungluu
4 years, 5 months ago (2016-06-28 22:41:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
de6c20aad64d53a7061c10e724e9924cfec679f6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698