Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2104123002:
[css-flexbox] childIntrinsicWidth needs to actually return the intrinsic width (Closed)
|
Created:
4 years, 5 months ago by cbiesinger Modified:
4 years, 5 months ago CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[css-flexbox] childIntrinsicWidth needs to actually return the intrinsic width
This function is used to determine the cross size of a flex
line. If we just use .width() then it is potentially affected
by a previous layout where we already stretched the child.
To avoid that, switch to maxPreferredLogicalWidth() --
we already use that in childIntrinsicHeight, and we also
use intrinsicContentLogicalHeight() for the height case.
However, if we have a non-auto width, we can't necessarily
just call maxPreferredLogicalWidth; the preferred width
may not have percentages correctly resolved, for example.
TEST=css3/flexbox/wrapping-column-dynamic-changes.html
BUG=607856, 607262
Committed: https://crrev.com/c83fe889c7045ad03b0b0a2e8d4fdcf1330d29ce
Cr-Commit-Position: refs/heads/master@{#402932}
Patch Set 1 #Patch Set 2 : add test #Patch Set 3 : had to make this more similar to childIntrinsicHeight to fix tests #
Messages
Total messages: 26 (15 generated)
The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [css-flexbox] childIntrinsicWidth needs to actually return the intrinsic width BUG=607856,607262 ========== to ========== [css-flexbox] childIntrinsicWidth needs to actually return the intrinsic width This function is used to determine the cross size of a flex line. If we just use .width() then it is potentially affected by a previous layout where we already stretched the child. To avoid that, switch to maxPreferredLogicalWidth() -- we already use that in childIntrinsicHeight, and we also use intrinsicContentLogicalHeight() for the height case. BUG=607856,607262 ==========
cbiesinger@chromium.org changed reviewers: + dgrogan@chromium.org, eae@chromium.org
The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM
The CQ bit was unchecked by cbiesinger@google.com
The CQ bit was checked by cbiesinger@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [css-flexbox] childIntrinsicWidth needs to actually return the intrinsic width This function is used to determine the cross size of a flex line. If we just use .width() then it is potentially affected by a previous layout where we already stretched the child. To avoid that, switch to maxPreferredLogicalWidth() -- we already use that in childIntrinsicHeight, and we also use intrinsicContentLogicalHeight() for the height case. BUG=607856,607262 ========== to ========== [css-flexbox] childIntrinsicWidth needs to actually return the intrinsic width This function is used to determine the cross size of a flex line. If we just use .width() then it is potentially affected by a previous layout where we already stretched the child. To avoid that, switch to maxPreferredLogicalWidth() -- we already use that in childIntrinsicHeight, and we also use intrinsicContentLogicalHeight() for the height case. TEST=css3/flexbox/wrapping-column-dynamic-changes.html BUG=607856,607262 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by cbiesinger@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org Link to the patchset: https://codereview.chromium.org/2104123002/#ps40001 (title: "had to make this more similar to childIntrinsicHeight to fix tests")
Description was changed from ========== [css-flexbox] childIntrinsicWidth needs to actually return the intrinsic width This function is used to determine the cross size of a flex line. If we just use .width() then it is potentially affected by a previous layout where we already stretched the child. To avoid that, switch to maxPreferredLogicalWidth() -- we already use that in childIntrinsicHeight, and we also use intrinsicContentLogicalHeight() for the height case. TEST=css3/flexbox/wrapping-column-dynamic-changes.html BUG=607856,607262 ========== to ========== [css-flexbox] childIntrinsicWidth needs to actually return the intrinsic width This function is used to determine the cross size of a flex line. If we just use .width() then it is potentially affected by a previous layout where we already stretched the child. To avoid that, switch to maxPreferredLogicalWidth() -- we already use that in childIntrinsicHeight, and we also use intrinsicContentLogicalHeight() for the height case. However, if we have a non-auto width, we can't necessarily just call maxPreferredLogicalWidth; the preferred width may not have percentages correctly resolved, for example. TEST=css3/flexbox/wrapping-column-dynamic-changes.html BUG=607856,607262 ==========
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by cbiesinger@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [css-flexbox] childIntrinsicWidth needs to actually return the intrinsic width This function is used to determine the cross size of a flex line. If we just use .width() then it is potentially affected by a previous layout where we already stretched the child. To avoid that, switch to maxPreferredLogicalWidth() -- we already use that in childIntrinsicHeight, and we also use intrinsicContentLogicalHeight() for the height case. However, if we have a non-auto width, we can't necessarily just call maxPreferredLogicalWidth; the preferred width may not have percentages correctly resolved, for example. TEST=css3/flexbox/wrapping-column-dynamic-changes.html BUG=607856,607262 ========== to ========== [css-flexbox] childIntrinsicWidth needs to actually return the intrinsic width This function is used to determine the cross size of a flex line. If we just use .width() then it is potentially affected by a previous layout where we already stretched the child. To avoid that, switch to maxPreferredLogicalWidth() -- we already use that in childIntrinsicHeight, and we also use intrinsicContentLogicalHeight() for the height case. However, if we have a non-auto width, we can't necessarily just call maxPreferredLogicalWidth; the preferred width may not have percentages correctly resolved, for example. TEST=css3/flexbox/wrapping-column-dynamic-changes.html BUG=607856,607262 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [css-flexbox] childIntrinsicWidth needs to actually return the intrinsic width This function is used to determine the cross size of a flex line. If we just use .width() then it is potentially affected by a previous layout where we already stretched the child. To avoid that, switch to maxPreferredLogicalWidth() -- we already use that in childIntrinsicHeight, and we also use intrinsicContentLogicalHeight() for the height case. However, if we have a non-auto width, we can't necessarily just call maxPreferredLogicalWidth; the preferred width may not have percentages correctly resolved, for example. TEST=css3/flexbox/wrapping-column-dynamic-changes.html BUG=607856,607262 ========== to ========== [css-flexbox] childIntrinsicWidth needs to actually return the intrinsic width This function is used to determine the cross size of a flex line. If we just use .width() then it is potentially affected by a previous layout where we already stretched the child. To avoid that, switch to maxPreferredLogicalWidth() -- we already use that in childIntrinsicHeight, and we also use intrinsicContentLogicalHeight() for the height case. However, if we have a non-auto width, we can't necessarily just call maxPreferredLogicalWidth; the preferred width may not have percentages correctly resolved, for example. TEST=css3/flexbox/wrapping-column-dynamic-changes.html BUG=607856,607262 Committed: https://crrev.com/c83fe889c7045ad03b0b0a2e8d4fdcf1330d29ce Cr-Commit-Position: refs/heads/master@{#402932} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/c83fe889c7045ad03b0b0a2e8d4fdcf1330d29ce Cr-Commit-Position: refs/heads/master@{#402932} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
