appengine/findit/model/wf_culprit.py - Issue 2104113002: [Findit] Add settings for actions after culprits or suspects are identified.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/model/wf_culprit.py

Issue 2104113002: [Findit] Add settings for actions after culprits or suspects are identified. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@group_same_failures

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/findit/model/wf_config.py ('k') | appengine/findit/templates/config.html » ('j') | appengine/findit/waterfall/send_notification_for_culprit_pipeline.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/model/wf_culprit.py

diff --git a/appengine/findit/model/wf_culprit.py b/appengine/findit/model/wf_culprit.py

index f40882b5a3bd96388897eeafb5bc0db306017cee..182094f27a3961e38f797242e4051e20c6164531 100644

--- a/appengine/findit/model/wf_culprit.py

+++ b/appengine/findit/model/wf_culprit.py

@@ -22,7 +22,8 @@ class WfCulprit(ndb.Model):

# When the code-review of this culprit was notified.

cr_notification_time = ndb.DateTimeProperty(indexed=True)

- # The status of code-review notification: None, RUNNING, COMPLETED, ERROR.

+ # The status of code-review notification:

+ # None, RUNNING, COMPLETED, ERROR, SKIPPED.

cr_notification_status = ndb.IntegerProperty(indexed=True)

# The list of builds in which the culprit caused some breakage.

@@ -34,7 +35,8 @@ class WfCulprit(ndb.Model):

@property

def cr_notification_processed(self):

- return self.cr_notification_status in (status.COMPLETED, status.RUNNING)

+ return self.cr_notification_status in (

+ status.COMPLETED, status.RUNNING, status.SKIPPED)

@property

def cr_notified(self):