third_party/WebKit/LayoutTests/csspaint/paint2d-zoom.html - Issue 2104103003: Fix zoom in CSS paint worklets

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/csspaint/paint2d-zoom.html

Issue 2104103003: Fix zoom in CSS paint worklets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/csspaint/paint2d-zoom-expected.html » ('j') | third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../resources/run-after-layout-and-paint.js"></script>	4 <script src="../resources/run-after-layout-and-paint.js"></script>

5 <script src="resources/test-runner-paint-worklet.js"></script>	5 <script src="resources/test-runner-paint-worklet.js"></script>

6 <style>	6 <style>

7 #output {	7 #output {

8 width: 100px;	8 width: 100px;

9 height: 100px;	9 height: 100px;

10 background-image: paint(error);	10 background-image: paint(worklet);

11 background-color: green;

12 }	11 }

13 </style>	12 </style>

14 </head>	13 </head>

15 <body>	14 <body>

16 <div id="output"></div>	15 <div id="output"></div>

17	16

18 <script id="code" type="text/worklet">	17 <script id="code" type="text/worklet">

19 registerPaint('error', class {	18 registerPaint('worklet', class {

20 paint(ctx, geom) {	19 paint(ctx, geom) {

21 ctx.fillStyle = 'red';	20 ctx.strokeStyle = 'blue';

22 ctx.fillRect(0, 0, geom.width, geom.height);	21 ctx.lineWidth = 4;

23 throw Error('failed!');	22 ctx.strokeRect(20, 20, 60, 60);
	Justin Novosad 2016/07/04 15:45:58 Using a pixel-aligned rect prevents the test from Using a pixel-aligned rect prevents the test from verifying that content was rasterized at the right resolution. I think it would be important to check that the SkPicture was playedback at 300x300. Gleb Lanbin 2016/07/06 20:36:18 Justin, can you please advice how can I do that? I Show quoted text On 2016/07/04 15:45:58, Justin Novosad wrote: > Using a pixel-aligned rect prevents the test from verifying that content was > rasterized at the right resolution. I think it would be important to check that > the SkPicture was playedback at 300x300. Justin, can you please advice how can I do that? I tried to use internals.layerTreeAsText but it doesn't expose that data.
	23 console.log('width: ' + geom.width + ', height: ' + geom.height);

24 }	24 }

25 });	25 });

26 </script>	26 </script>

27	27

28 <script>	28 <script>

	29 if (window.testRunner) window.testRunner.dumpAsTextWithPixelResults();

	30 document.body.style.zoom = "300%";

	31 console.log('The worklet should log: \'width: 100, height: 100\'');

29 importPaintWorkletAndTerminateTestAfterAsyncPaint(document.getElementById('c ode').textContent);	32 importPaintWorkletAndTerminateTestAfterAsyncPaint(document.getElementById('c ode').textContent);

30 </script>	33 </script>

31 </body>	34 </body>

32 </html>	35 </html>

OLD	NEW