ui/webui/resources/js/cr/ui/menu.js - Issue 2104103002: Convert Event#keyIdentifier (deprecated) to Event#key

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/js/cr/ui/menu.js

Issue 2104103002: Convert Event#keyIdentifier (deprecated) to Event#key (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/webui/resources/js/cr/ui/command.js ('K') | « ui/webui/resources/js/cr/ui/list_selection_controller.js ('k') | ui/webui/resources/js/cr/ui/menu_button.js » ('j') | ui/webui/resources/js/cr/ui/menu_item.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/webui/resources/js/cr/ui/menu.js

diff --git a/ui/webui/resources/js/cr/ui/menu.js b/ui/webui/resources/js/cr/ui/menu.js

index abcb79c71906f6a6fb1f83f7617f183d54699281..fbf0522c48b1466fe1004491e1bee3ba15f5548b 100644

--- a/ui/webui/resources/js/cr/ui/menu.js

+++ b/ui/webui/resources/js/cr/ui/menu.js

@@ -241,17 +241,17 @@ cr.define('cr.ui', function() {

self.selectedIndex = i;

}

- switch (e.keyIdentifier) {

- case 'Down':

+ switch (e.key) {

+ case 'ArrowDown':

selectNextAvailable(1);

this.focusSelectedItem();

return true;

- case 'Up':

+ case 'ArrowUp':

selectNextAvailable(-1);

this.focusSelectedItem();

return true;

case 'Enter':

- case 'U+0020': // Space

+ case ' ':

if (item) {

// Store |contextElement| since it'll be removed when handling the

// 'activate' event.