ui/webui/resources/js/cr/ui/focus_row.js - Issue 2104103002: Convert Event#keyIdentifier (deprecated) to Event#key

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/js/cr/ui/focus_row.js

Issue 2104103002: Convert Event#keyIdentifier (deprecated) to Event#key (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/webui/resources/js/cr/ui/command.js ('K') | « ui/webui/resources/js/cr/ui/focus_grid.js ('k') | ui/webui/resources/js/cr/ui/list_selection_controller.js » ('j') | ui/webui/resources/js/cr/ui/menu_item.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/webui/resources/js/cr/ui/focus_row.js

diff --git a/ui/webui/resources/js/cr/ui/focus_row.js b/ui/webui/resources/js/cr/ui/focus_row.js

index a545d14d7be535be01233dbee25fdcbb88e37ce9..e612cbc1dbd51b8c4dbeabe8863f282615fb7d8c 100644

--- a/ui/webui/resources/js/cr/ui/focus_row.js

+++ b/ui/webui/resources/js/cr/ui/focus_row.js

@@ -271,13 +271,13 @@ cr.define('cr.ui', function() {

var index = -1;

- if (e.keyIdentifier == 'Left')

+ if (e.key == 'ArrowLeft')

index = elementIndex + (isRTL() ? 1 : -1);

- else if (e.keyIdentifier == 'Right')

+ else if (e.key == 'ArrowRight')

index = elementIndex + (isRTL() ? -1 : 1);

- else if (e.keyIdentifier == 'Home')

+ else if (e.key == 'Home')

index = 0;

- else if (e.keyIdentifier == 'End')

+ else if (e.key == 'End')

index = elements.length - 1;

var elementToFocus = elements[index];