ui/webui/resources/js/cr/ui/context_menu_handler.js - Issue 2104103002: Convert Event#keyIdentifier (deprecated) to Event#key

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/js/cr/ui/context_menu_handler.js

Issue 2104103002: Convert Event#keyIdentifier (deprecated) to Event#key (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/webui/resources/js/cr/ui/command.js ('K') | « ui/webui/resources/js/cr/ui/command.js ('k') | ui/webui/resources/js/cr/ui/focus_grid.js » ('j') | ui/webui/resources/js/cr/ui/menu_item.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/webui/resources/js/cr/ui/context_menu_handler.js

diff --git a/ui/webui/resources/js/cr/ui/context_menu_handler.js b/ui/webui/resources/js/cr/ui/context_menu_handler.js

index 0c9bb7ad9d17040d4ce42d0f288364f6ff1454a7..7a48736e36a60635f7d64ea8e5bb516aa19321b1 100644

--- a/ui/webui/resources/js/cr/ui/context_menu_handler.js

+++ b/ui/webui/resources/js/cr/ui/context_menu_handler.js

@@ -137,8 +137,7 @@ cr.define('cr.ui', function() {

case 'keydown':

this.keyIsDown_ = !e.ctrlKey && !e.altKey &&

// context menu key or Shift-F10

- (e.keyCode == 93 && !e.shiftKey ||

- e.keyIdentifier == 'F10' && e.shiftKey);

+ (e.keyCode == 93 && !e.shiftKey || e.key == 'F10' && e.shiftKey);

break;

case 'keyup':

@@ -169,8 +168,7 @@ cr.define('cr.ui', function() {

break;

case 'keydown':

- // keyIdentifier does not report 'Esc' correctly

- if (e.keyCode == 27 /* Esc */) {

+ if (e.key == 'Escape') {

this.hideMenu();

e.stopPropagation();

e.preventDefault();