chrome/common/extensions/docs/examples/extensions/plugin_settings/options/js/inline_editable_list.js - Issue 2104103002: Convert Event#keyIdentifier (deprecated) to Event#key

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/examples/extensions/plugin_settings/options/js/inline_editable_list.js

Issue 2104103002: Convert Event#keyIdentifier (deprecated) to Event#key (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/md_downloads/downloads.html ('K') | « chrome/common/extensions/docs/examples/extensions/plugin_settings/domui/js/cr/ui/list_selection_controller.js ('k') | chrome/renderer/resources/plugins/plugin_poster.html » ('j') | chrome/test/data/webui/inline_editable_list_test.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/examples/extensions/plugin_settings/options/js/inline_editable_list.js

diff --git a/chrome/common/extensions/docs/examples/extensions/plugin_settings/options/js/inline_editable_list.js b/chrome/common/extensions/docs/examples/extensions/plugin_settings/options/js/inline_editable_list.js

index 8aed93beedf423fe5d24ca8c6f317fa50979672e..c09d920790f63cff8afdb3f8ee898ea6f8afb79e 100644

--- a/chrome/common/extensions/docs/examples/extensions/plugin_settings/options/js/inline_editable_list.js

+++ b/chrome/common/extensions/docs/examples/extensions/plugin_settings/options/js/inline_editable_list.js

@@ -305,8 +305,8 @@ cr.define('options', function() {

return;

var endEdit = false;

- switch (e.keyIdentifier) {

- case 'U+001B': // Esc

+ switch (e.key) {

+ case 'Escape':

this.editCancelled_ = true;

endEdit = true;

break;