chrome/browser/ui/webui/options/options_browsertest.js - Issue 2104103002: Convert Event#keyIdentifier (deprecated) to Event#key

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/options_browsertest.js

Issue 2104103002: Convert Event#keyIdentifier (deprecated) to Event#key (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/md_downloads/downloads.html ('K') | « chrome/browser/resources/md_downloads/vulcanized.html ('k') | chrome/common/extensions/docs/examples/extensions/plugin_settings/domui/js/cr/ui/list_selection_controller.js » ('j') | chrome/test/data/webui/inline_editable_list_test.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/options_browsertest.js

diff --git a/chrome/browser/ui/webui/options/options_browsertest.js b/chrome/browser/ui/webui/options/options_browsertest.js

index ec1e8bc62f87e1f76071888eb252026b9e5a2cc7..c80a4efced864f296f90421df4f84e700a361dcf 100644

--- a/chrome/browser/ui/webui/options/options_browsertest.js

+++ b/chrome/browser/ui/webui/options/options_browsertest.js

@@ -321,7 +321,7 @@ TEST_F('OptionsWebUITest', 'EnterPreventsDefault', function() {

var event = new KeyboardEvent('keydown', {

'bubbles': true,

'cancelable': true,

- 'keyIdentifier': 'Enter'

+ 'key': 'Enter'

});

assertFalse(event.defaultPrevented);

page.pageDiv.dispatchEvent(event);