ui/webui/resources/js/cr/ui/focus_grid.js - Issue 2104103002: Convert Event#keyIdentifier (deprecated) to Event#key

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/js/cr/ui/focus_grid.js

Issue 2104103002: Convert Event#keyIdentifier (deprecated) to Event#key (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Patch file manager test Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/webui/resources/js/cr/ui/focus_grid.js

diff --git a/ui/webui/resources/js/cr/ui/focus_grid.js b/ui/webui/resources/js/cr/ui/focus_grid.js

index 4eda10b6af0d4363ecad551917235c541c8c72ac..cd3205ef2f7d6d300b15cabba0d469b8e782373a 100644

--- a/ui/webui/resources/js/cr/ui/focus_grid.js

+++ b/ui/webui/resources/js/cr/ui/focus_grid.js

@@ -53,13 +53,13 @@ cr.define('cr.ui', function() {

var newRow = -1;

- if (e.keyIdentifier == 'Up')

+ if (e.key == 'ArrowUp')

newRow = rowIndex - 1;

- else if (e.keyIdentifier == 'Down')

+ else if (e.key == 'ArrowDown')

newRow = rowIndex + 1;

- else if (e.keyIdentifier == 'PageUp')

+ else if (e.key == 'PageUp')

newRow = 0;

- else if (e.keyIdentifier == 'PageDown')

+ else if (e.key == 'PageDown')

newRow = this.rows.length - 1;

var rowToFocus = this.rows[newRow];

« no previous file with comments | « ui/webui/resources/js/cr/ui/context_menu_handler.js ('k') | ui/webui/resources/js/cr/ui/focus_row.js » ('j') | no next file with comments »