ui/webui/resources/js/cr/link_controller.js - Issue 2104103002: Convert Event#keyIdentifier (deprecated) to Event#key

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/js/cr/link_controller.js

Issue 2104103002: Convert Event#keyIdentifier (deprecated) to Event#key (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Patch file manager test Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/webui/resources/js/cr/link_controller.js

diff --git a/ui/webui/resources/js/cr/link_controller.js b/ui/webui/resources/js/cr/link_controller.js

index e643eefb1c378c078868c196631e2502aee0d896..0e93f75909bacad8c24bdcfbb6c3e27922301a62 100644

--- a/ui/webui/resources/js/cr/link_controller.js

+++ b/ui/webui/resources/js/cr/link_controller.js

@@ -81,8 +81,7 @@ cr.define('cr', function() {

openUrlFromEvent: function(url, e) {

// We only support keydown Enter and non right click events.

- if (e.type == 'keydown' && e.keyIdentifier == 'Enter' ||

- e.button != 2) {

+ if (e.type == 'keydown' && e.key == 'Enter' || e.button != 2) {

var kind;

var ctrl = cr.isMac && e.metaKey || !cr.isMac && e.ctrlKey;

« no previous file with comments | « ui/webui/resources/js/action_link.js ('k') | ui/webui/resources/js/cr/ui/autocomplete_list.js » ('j') | no next file with comments »