Convert Event#keyIdentifier (deprecated) to Event#key

ui/login/bubble.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Bubble implementation.
  */
 
 // TODO(xiyuan): Move this into shared.
 cr.define('cr.ui', function() {
   /**
    * Creates a bubble div.
    * @constructor
    * @extends {HTMLDivElement}
    */
   var Bubble = cr.ui.define('div');
 
   /**
    * Bubble key codes.
    * @enum {number}
    */
   var KeyCodes = {

[Dan Beam, 2016/06/29 23:34:17]

nit: KeyCodes => Keys

[dtapuska, 2016/06/30 14:16:50]

Done.

-    TAB: 'U+0009',
+    TAB: 'Tab',
     ENTER: 'Enter',
-    ESC: 'U+001B',
-    SPACE: 'U+0020'
+    ESC: 'Escape',
+    SPACE: ' '
   };
 
   /**
    * Bubble attachment side.
    * @enum {string}
    */
   Bubble.Attachment = {
     RIGHT: 'bubble-right',
     LEFT: 'bubble-left',
     TOP: 'bubble-top',
@@ skipping 283 matching lines @@
     handleDocKeyDown_: function(e) {
       if (this.hidden)
         return;
 
       if (this.hideOnKeyPress_) {
         this.hide();
         return;
       }
       // Artificial tab-cycle.
 
-      if (e.keyIdentifier == KeyCodes.TAB && e.shiftKey == true &&
+      if (e.key == KeyCodes.TAB && e.shiftKey == true &&
           e.target == this.firstBubbleElement_) {
         this.lastBubbleElement_.focus();
         e.preventDefault();
       }
-      if (e.keyIdentifier == KeyCodes.TAB && e.shiftKey == false &&
+      if (e.key == KeyCodes.TAB && e.shiftKey == false &&
           e.target == this.lastBubbleElement_) {
         this.firstBubbleElement_.focus();
         e.preventDefault();
       }
       // Close bubble on ESC or on hitting spacebar or Enter at close-button.
-      if (e.keyIdentifier == KeyCodes.ESC ||
-          ((e.keyIdentifier == KeyCodes.ENTER ||
-            e.keyIdentifier == KeyCodes.SPACE) &&
+      if (e.key == KeyCodes.ESC ||
+          ((e.key == KeyCodes.ENTER ||
+            e.key == KeyCodes.SPACE) &&
              e.target && e.target.classList.contains('close-button')))
         this.hide();
     },
 
     /**
      * Handler of window blur event.
      * @private
      */
     handleWindowBlur_: function(e) {
       if (!this.hidden)
         this.hide();
     }
   };
 
   return {
     Bubble: Bubble
   };
 });