chrome/test/data/webui/inline_editable_list_test.html - Issue 2104103002: Convert Event#keyIdentifier (deprecated) to Event#key

Side by Side Diff: chrome/test/data/webui/inline_editable_list_test.html

Issue 2104103002: Convert Event#keyIdentifier (deprecated) to Event#key (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix nits Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <body>	3 <body>

4	4

5 <script>	5 <script>

6	6

7 function setUp() {	7 function setUp() {

8 loadTimeData.data = {	8 loadTimeData.data = {

9 'deletableItemDeleteButtonTitle': 'test_deletable_button_title'	9 'deletableItemDeleteButtonTitle': 'test_deletable_button_title'

10 };	10 };

(...skipping 90 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
101 // Export.	101 // Export.

102 return {	102 return {

103 TestItemList: TestItemList	103 TestItemList: TestItemList

104 };	104 };

105	105

106 })	106 })

107 }	107 }

108	108

109 /**	109 /**

110 * @param {!EventTarget} target Where to send the event.	110 * @param {!EventTarget} target Where to send the event.

111 * @param {!string} keyIdentifier Which key to send.	111 * @param {!string} key Which key to send.

112 */	112 */

113 function sendKeyDownEvent(target, keyIdentifier) {	113 function sendKeyDownEvent(target, key) {

114 var event = document.createEvent('KeyboardEvent');	114 var event = new KeyboardEvent('keydown', {bubbles: true, cancelable: true, key : key});
	Dan Beam 2016/06/29 23:34:17 this should wrap at 80 cols this should wrap at 80 cols dtapuska 2016/06/30 14:16:50 Done. Show quoted text On 2016/06/29 23:34:17, Dan Beam wrote: > this should wrap at 80 cols Done.
115 event.initKeyboardEvent('keydown', true, true, window, keyIdentifier);

116 assertEquals(keyIdentifier, event.keyIdentifier);

117 target.dispatchEvent(event);	115 target.dispatchEvent(event);

118 }	116 }

119	117

120 /**	118 /**

121 * Test that exactly one item in the list is focusable after navigating the	119 * Test that exactly one item in the list is focusable after navigating the

122 * list using up and down arrow keys.	120 * list using up and down arrow keys.

123 */	121 */

124 function testUpDownFocus() {	122 function testUpDownFocus() {

125 var list = document.createElement('ul');	123 var list = document.createElement('ul');

126 list.style.position = 'absolute';	124 list.style.position = 'absolute';

127 list.style.width = '800px';	125 list.style.width = '800px';

128 list.style.height = '800px';	126 list.style.height = '800px';

129 options.TestItemList.decorate(list);	127 options.TestItemList.decorate(list);

130 document.body.appendChild(list);	128 document.body.appendChild(list);

131	129

132 var model = new cr.ui.ArrayDataModel(['itemA', 'itemB', 'itemC']);	130 var model = new cr.ui.ArrayDataModel(['itemA', 'itemB', 'itemC']);

133 list.dataModel = model;	131 list.dataModel = model;

134 list.selectionModel.setIndexSelected(0, true);	132 list.selectionModel.setIndexSelected(0, true);

135 list.selectionModel.leadIndex = 0;	133 list.selectionModel.leadIndex = 0;

136	134

137 assertTrue(list.hasExactlyOneItemFocusable(0));	135 assertTrue(list.hasExactlyOneItemFocusable(0));

138 sendKeyDownEvent(list, 'Down');	136 sendKeyDownEvent(list, 'ArrowDown');

139 assertTrue(list.hasExactlyOneItemFocusable(1));	137 assertTrue(list.hasExactlyOneItemFocusable(1));

140 sendKeyDownEvent(list, 'Down');	138 sendKeyDownEvent(list, 'ArrowDown');

141 assertTrue(list.hasExactlyOneItemFocusable(2));	139 assertTrue(list.hasExactlyOneItemFocusable(2));

142 sendKeyDownEvent(list, 'Up');	140 sendKeyDownEvent(list, 'ArrowUp');

143 assertTrue(list.hasExactlyOneItemFocusable(1));	141 assertTrue(list.hasExactlyOneItemFocusable(1));

144 sendKeyDownEvent(list, 'Up');	142 sendKeyDownEvent(list, 'ArrowUp');

145 assertTrue(list.hasExactlyOneItemFocusable(0));	143 assertTrue(list.hasExactlyOneItemFocusable(0));

146 sendKeyDownEvent(list, 'Down');	144 sendKeyDownEvent(list, 'ArrowDown');

147 assertTrue(list.hasExactlyOneItemFocusable(1));	145 assertTrue(list.hasExactlyOneItemFocusable(1));

148 }	146 }

149	147

150 </script>	148 </script>

151	149

152 </body>	150 </body>

153 </html>	151 </html>

OLD	NEW

« chrome/browser/resources/md_downloads/downloads.html ('K') | « chrome/test/data/webui/history_browsertest.js ('k') | ui/file_manager/file_manager/main.html » ('j') | ui/login/bubble.js » ('J')