chrome/browser/resources/md_downloads/downloads.html - Issue 2104103002: Convert Event#keyIdentifier (deprecated) to Event#key

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/md_downloads/downloads.html

Issue 2104103002: Convert Event#keyIdentifier (deprecated) to Event#key (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix nits Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/md_downloads/crisper.js ('k') | chrome/browser/resources/md_downloads/vulcanized.html » ('j') | chrome/test/data/webui/inline_editable_list_test.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html dir="$i18n{textdirection}" lang="$i18n{language}">	2 <html dir="$i18n{textdirection}" lang="$i18n{language}">

3 <head>	3 <head>

4 <meta charset="utf-8">	4 <meta charset="utf-8">

5 <title>$i18n{title}</title>	5 <title>$i18n{title}</title>

6 <link rel="stylesheet" href="chrome://resources/css/text_defaults_md.css">	6 <link rel="stylesheet" href="chrome://resources/css/text_defaults_md.css">

7 <link rel="stylesheet" href="chrome://resources/css/md_colors.css">	7 <link rel="stylesheet" href="chrome://resources/css/md_colors.css">

8 <style>	8 <style>

9 html {	9 html {

10 background: var(--md-background-color);	10 background: var(--md-background-color);

11 }	11 }

12	12

13 html,	13 html,

14 body {	14 body {

15 height: 100%;	15 height: 100%;

16 }	16 }

17	17

18 body {	18 body {

19 display: flex;	19 display: flex;

20 margin: 0;	20 margin: 0;

21 }	21 }

22 </style>	22 </style>

23 </head>	23 </head>

24 <body>	24 <body>

25 <downloads-manager></downloads-manager>	25 <downloads-manager></downloads-manager>

26 <command id="clear-all-command" shortcut="Alt-U+0043"><!-- Alt+C -->	26 <command id="clear-all-command" shortcut="Alt\|c"><!-- Alt+C -->

27 <if expr="is_macosx">	27 <if expr="is_macosx">

28 <command id="undo-command" shortcut="Meta-U+005A"><!-- Command+Z -->	28 <command id="undo-command" shortcut="Meta\|z"><!-- Command+Z -->

29 <command id="find-command" shortcut="Meta-U+0046"><!-- Command+F -->	29 <command id="find-command" shortcut="Meta\|f"><!-- Command+F -->

30 </if>	30 </if>

31 <if expr="not is_macosx">	31 <if expr="not is_macosx">

32 <command id="undo-command" shortcut="Ctrl-U+005A"><!-- Ctrl+Z -->	32 <command id="undo-command" shortcut="Ctrl\|z"><!-- Ctrl+Z -->

33 <command id="find-command" shortcut="Ctrl-U+0046"><!-- Ctrl+F -->	33 <command id="find-command" shortcut="Ctrl\|f"><!-- Ctrl+F -->
	Dan Beam 2016/06/29 23:34:17 you can probably remove all these HTML comments no you can probably remove all these HTML comments now (the shortcut="" itself looks clear enough) dtapuska 2016/06/30 14:16:50 Done. Show quoted text On 2016/06/29 23:34:17, Dan Beam wrote: > you can probably remove all these HTML comments now (the shortcut="" itself > looks clear enough) Done.
34 </if>	34 </if>

35 <link rel="import" href="chrome://resources/html/polymer.html">	35 <link rel="import" href="chrome://resources/html/polymer.html">

36 <link rel="import" href="chrome://downloads/i18n_setup.html">	36 <link rel="import" href="chrome://downloads/i18n_setup.html">

37 <link rel="import" href="chrome://downloads/manager.html">	37 <link rel="import" href="chrome://downloads/manager.html">

38 <script src="chrome://downloads/downloads.js"></script>	38 <script src="chrome://downloads/downloads.js"></script>

39 </body>	39 </body>

40 </html>	40 </html>

OLD	NEW