Convert Event#keyIdentifier (deprecated) to Event#key

ui/webui/resources/js/util.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // <include src="assert.js">
 
 /**
  * Alias for document.getElementById. Found elements must be HTMLElements.
  * @param {string} id The ID of the element to find.
  * @return {HTMLElement} The found element or null if not found.
@@ skipping 354 matching lines @@
 }
 
 /**
  * Quote a string so it can be used in a regular expression.
  * @param {string} str The source string.
  * @return {string} The escaped string.
  */
 function quoteString(str) {
   return str.replace(/([\\\.\+\*\?\[\^\]\$\(\)\{\}\=\!\<\>\|\:])/g, '\\$1');
 }
+

[Dan Beam, 2016/06/29 18:28:09]

nit: remove extra \n

[dtapuska, 2016/06/29 20:09:02]

Done.

+
+// Polyfill 'key' in KeyboardEvent for iOS.
+// This function is not intended to be complete but should
+// be sufficient enough to have iOS work correctly while
+// it does not support key yet.
+if (!('key' in KeyboardEvent.prototype)) {

[Dan Beam, 2016/06/29 18:28:09]

I think it's cool that you're doing runtime feature detection, BUT, we still
ship this extra code with Chrome for no reason everywhere but iOS :(

can we wrap this in a

  <if expr="is_ios">

and maybe keep the feature detection if they implement it or something?  or
maybe assert(!('key' in KeyboardEvent.prototype')); so that we'll know when they
do implement it (or something that warns rather than throws would probably be
better)?

[dtapuska, 2016/06/29 20:09:02]

Done.

+  var keyGetter = {

[Dan Beam, 2016/06/29 18:28:09]

can we just inline keyGetter?  -1 global

Object.defineProperty(KeyboardEvent.prototype, 'key', {
  get: function() {
    ...
  },
});

[dtapuska, 2016/06/29 20:09:02]

Done.

+    get: function () {
+      // 0-9
+      if (this.keyCode >= 0x30 && this.keyCode <= 0x39)
+          return String.fromCharCode(this.keyCode);

[Dan Beam, 2016/06/29 18:28:09]

indent off

[dtapuska, 2016/06/29 20:09:02]

Done.

+
+      // A-Z
+      if (this.keyCode >= 0x41 && this.keyCode <= 0x5a) {
+          var result = String.fromCharCode(this.keyCode).toLowerCase();
+          if (this.shiftKey)
+            result = result.toUpperCase();
+          return result;

[Dan Beam, 2016/06/29 18:28:09]

indent off

[dtapuska, 2016/06/29 20:09:02]

Done.

+      }
+
+      // Special characters
+      switch(this.keyCode) {
+        case 0x08: return 'Backspace';
+        case 0x09: return 'Tab';
+        case 0x0d: return 'Enter';
+        case 0x10: return 'Shift';
+        case 0x11: return 'Control';
+        case 0x12: return 'Alt';
+        case 0x1b: return 'Escape';
+        case 0x20: return ' ';
+        case 0x21: return 'PageUp';
+        case 0x22: return 'PageDown';
+        case 0x23: return 'End';
+        case 0x24: return 'Home';
+        case 0x25: return 'ArrowLeft';
+        case 0x26: return 'ArrowUp';
+        case 0x27: return 'ArrowRight';
+        case 0x28: return 'ArrowDown';
+        case 0x2d: return 'Insert';
+        case 0x2e: return 'Delete';
+        case 0x5b: return 'Meta';
+        case 0x70: return 'F1';
+        case 0x71: return 'F2';
+        case 0x72: return 'F3';
+        case 0x73: return 'F4';
+        case 0x74: return 'F5';
+        case 0x75: return 'F6';
+        case 0x76: return 'F7';
+        case 0x77: return 'F8';
+        case 0x78: return 'F9';
+        case 0x79: return 'F10';
+        case 0x7a: return 'F11';
+        case 0x7b: return 'F12';
+        case 0xbb: return '=';
+        case 0xbd: return '-';
+        case 0xdb: return '[';
+        case 0xdd: return ']';
+      }
+      return 'Unidentified';
+    }
+  };
+  Object.defineProperty(KeyboardEvent.prototype, 'key', keyGetter);
+}