Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issue 21041003: Implement Worker-MainThread bridge for FileWriter in Chrome (Closed)

Created:
7 years, 4 months ago by kinuko
Modified:
7 years, 4 months ago
Reviewers:
michaeln
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, kinuko+watch, jam, tzik+watch_chromium.org
Visibility:
Public.

Description

Implement Worker-MainThread bridge for FileWriter in Chrome This basically adds the same worker/mainThread bridge functionality for FileWriter in Chrome side. BUG=257349 TEST=no behavioral changes yet R=michaeln@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214957

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -40 lines) Patch
M content/child/fileapi/webfilesystem_impl.cc View 1 3 chunks +42 lines, -23 lines 0 comments Download
M content/child/fileapi/webfilewriter_impl.h View 3 chunks +10 lines, -3 lines 0 comments Download
M content/child/fileapi/webfilewriter_impl.cc View 1 chunk +95 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kinuko
One more bridge change... can you take a look? Thanks,
7 years, 4 months ago (2013-07-29 13:07:47 UTC) #1
michaeln
lgtm https://codereview.chromium.org/21041003/diff/13001/content/child/fileapi/webfilesystem_impl.cc File content/child/fileapi/webfilesystem_impl.cc (right): https://codereview.chromium.org/21041003/diff/13001/content/child/fileapi/webfilesystem_impl.cc#newcode213 content/child/fileapi/webfilesystem_impl.cc:213: } nit: the original conditional blocks were slightly ...
7 years, 4 months ago (2013-07-29 21:29:18 UTC) #2
kinuko
Thx! https://codereview.chromium.org/21041003/diff/13001/content/child/fileapi/webfilesystem_impl.cc File content/child/fileapi/webfilesystem_impl.cc (right): https://codereview.chromium.org/21041003/diff/13001/content/child/fileapi/webfilesystem_impl.cc#newcode213 content/child/fileapi/webfilesystem_impl.cc:213: } On 2013/07/29 21:29:18, michaeln wrote: > nit: ...
7 years, 4 months ago (2013-07-30 08:31:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/21041003/33001
7 years, 4 months ago (2013-07-30 18:11:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/21041003/33001
7 years, 4 months ago (2013-07-30 21:12:00 UTC) #5
kinuko
7 years, 4 months ago (2013-08-01 05:12:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r214957 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698