Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: runtime/vm/assembler_dbc_test.cc

Issue 2104093003: DBC: Implement OneByteStringFromCharCode and StringToCharCode. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: LoadConstant Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/constants_dbc.h » ('j') | runtime/vm/intermediate_language_dbc.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_dbc_test.cc
diff --git a/runtime/vm/assembler_dbc_test.cc b/runtime/vm/assembler_dbc_test.cc
index 9e4e2cdab4300fe276a5d6504b3ff0b804be6fec..c7fa0038049ddbe4f3d1627adaed3e8dfd6b0042 100644
--- a/runtime/vm/assembler_dbc_test.cc
+++ b/runtime/vm/assembler_dbc_test.cc
@@ -147,6 +147,46 @@ ASSEMBLER_TEST_GENERATE(StoreIntoObject, assembler) {
}
+ASSEMBLER_TEST_GENERATE(OneByteStringFromCharCode, assembler) {
zra 2016/06/29 14:34:12 I've been copying the comment from constants_dbc.h
rmacnak 2016/06/29 16:44:16 Done.
+ __ Frame(2);
+ __ LoadConstant(0, Smi::ZoneHandle(Smi::New(65)));
+ __ OneByteStringFromCharCode(1, 0);
+ __ Return(1);
+}
+
+
+ASSEMBLER_TEST_RUN(OneByteStringFromCharCode, test) {
+ EXPECT_EQ(Symbols::New(Thread::Current(), "A"),
+ EXECUTE_TEST_CODE_OBJECT(test->code()).raw());
+}
+
+
+ASSEMBLER_TEST_GENERATE(StringToCharCode, assembler) {
+ __ Frame(2);
+ __ LoadConstant(0, String::ZoneHandle(String::New("A", Heap::kOld)));
+ __ StringToCharCode(1, 0);
+ __ Return(1);
+}
+
+
+ASSEMBLER_TEST_RUN(StringToCharCode, test) {
+ EXPECT_EQ(65, EXECUTE_TEST_CODE_INTPTR(test->code()));
+}
+
+
+ASSEMBLER_TEST_GENERATE(StringToCharCodeIllegalLength, assembler) {
+ __ Frame(2);
+ __ LoadConstant(0, String::ZoneHandle(String::New("AAA", Heap::kOld)));
+ __ StringToCharCode(1, 0);
+ __ Return(1);
+}
+
+
+ASSEMBLER_TEST_RUN(StringToCharCodeIllegalLength, test) {
+ EXPECT_EQ(-1, EXECUTE_TEST_CODE_INTPTR(test->code()));
+}
+
+
// - AddTOS; SubTOS; MulTOS; BitOrTOS; BitAndTOS; EqualTOS; LessThanTOS;
// GreaterThanTOS;
//
« no previous file with comments | « no previous file | runtime/vm/constants_dbc.h » ('j') | runtime/vm/intermediate_language_dbc.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698