Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2104093003: DBC: Implement OneByteStringFromCharCode and StringToCharCode. (Closed)

Created:
4 years, 5 months ago by rmacnak
Modified:
4 years, 5 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

DBC: Implement OneByteStringFromCharCode and StringToCharCode. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/f84facd2843d638af8490bdf3c7052f0cdfb6f06

Patch Set 1 #

Patch Set 2 : LoadConstant #

Total comments: 7

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -2 lines) Patch
M runtime/vm/assembler_dbc_test.cc View 1 2 1 chunk +49 lines, -0 lines 0 comments Download
M runtime/vm/constants_dbc.h View 2 chunks +12 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_dbc.cc View 1 2 2 chunks +21 lines, -2 lines 0 comments Download
M runtime/vm/simulator_dbc.cc View 1 2 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rmacnak
4 years, 5 months ago (2016-06-29 00:26:06 UTC) #2
zra
lgtm with nits https://codereview.chromium.org/2104093003/diff/20001/runtime/vm/assembler_dbc_test.cc File runtime/vm/assembler_dbc_test.cc (right): https://codereview.chromium.org/2104093003/diff/20001/runtime/vm/assembler_dbc_test.cc#newcode150 runtime/vm/assembler_dbc_test.cc:150: ASSEMBLER_TEST_GENERATE(OneByteStringFromCharCode, assembler) { I've been copying ...
4 years, 5 months ago (2016-06-29 14:34:12 UTC) #3
rmacnak
https://codereview.chromium.org/2104093003/diff/20001/runtime/vm/assembler_dbc_test.cc File runtime/vm/assembler_dbc_test.cc (right): https://codereview.chromium.org/2104093003/diff/20001/runtime/vm/assembler_dbc_test.cc#newcode150 runtime/vm/assembler_dbc_test.cc:150: ASSEMBLER_TEST_GENERATE(OneByteStringFromCharCode, assembler) { On 2016/06/29 14:34:12, zra wrote: > ...
4 years, 5 months ago (2016-06-29 16:44:17 UTC) #4
rmacnak
4 years, 5 months ago (2016-06-29 16:44:37 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
f84facd2843d638af8490bdf3c7052f0cdfb6f06 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698