Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Issue 2104083002: Revert of Refactor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python. (Closed)

Created:
4 years, 5 months ago by Khushal
Modified:
4 years, 5 months ago
Reviewers:
Robert Sesek, scottmg
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Refactor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python. (patchset #1 id:1 of https://codereview.chromium.org/2108683002/ ) Reason for revert: A significant number of bots are broken after this landed. This is a speculative revert. Please re-land in case this was not the error. Original issue's description: > Refactor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python. > > When comparing large targets like //chrome, it is nearly impossible to deal with > the mountainous 46,000 lines of output the executable script produces. With an > interactive environment, it is much easier to compare differences and drill-down > into specific issues. > > BUG=622889 > R=scottmg@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/9f1375ea1bfb9f35e48b69f4c10c8ffa3233ca2a TBR=scottmg@chromium.org,rsesek@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=622889 Committed: https://crrev.com/74af4d66235496370bd173c6139314e8adfecb2e Cr-Commit-Position: refs/heads/master@{#402514}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -336 lines) Patch
M tools/gn/bin/gyp_flag_compare.py View 6 chunks +205 lines, -336 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Khushal
Created Revert of Refactor //tools/gn/bin/gyp_flag_compare.py to be usable in interactive Python.
4 years, 5 months ago (2016-06-28 19:53:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104083002/1
4 years, 5 months ago (2016-06-28 19:54:48 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 19:55:44 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/74af4d66235496370bd173c6139314e8adfecb2e Cr-Commit-Position: refs/heads/master@{#402514}
4 years, 5 months ago (2016-06-28 19:57:19 UTC) #6
Robert Sesek
4 years, 5 months ago (2016-06-28 20:15:43 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2110543003/ by rsesek@chromium.org.

The reason for reverting is: Revert unwarranted..

Powered by Google App Engine
This is Rietveld 408576698