Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 2104073002: Remove invalid assertion in store buffer code. (Closed)

Created:
4 years, 5 months ago by Florian Schneider
Modified:
4 years, 5 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove invalid assertion in store buffer code. This code is also used by other threads (e.g. background compiler). BUG=#26783 R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/3d4a7b1ca3f63d486eedcf7facab1d31f1bc6bb8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M runtime/vm/store_buffer.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
4 years, 5 months ago (2016-06-28 19:51:29 UTC) #2
siva
lgtm
4 years, 5 months ago (2016-06-28 20:13:38 UTC) #3
Florian Schneider
4 years, 5 months ago (2016-06-28 20:15:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3d4a7b1ca3f63d486eedcf7facab1d31f1bc6bb8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698