Add chrome.quickUnlockPrivate externs to closure

Add chrome.quickUnlockPrivate externs to closure

BUG=603217
Committed: https://crrev.com/c34468b226df93a22b9f196f87c440297b541f39
Cr-Commit-Position: refs/heads/master@{#402641}

[jdufault, 2016-06-28 22:24:34]

Description was changed from

==========
Add chrome.quickUnlockPrivate externs to closure

BUG=603217
==========

to

==========
Add chrome.quickUnlockPrivate externs to closure

BUG=603217
==========

[jdufault, 2016-06-28 22:24:34]

jdufault@chromium.org changed reviewers:
+ stevenjb@chromium.org

[jdufault, 2016-06-28 22:24:45]

Steven, PTAL. Thanks!

[stevenjb, 2016-06-28 22:30:21]

https://codereview.chromium.org/2104053003/diff/1/third_party/closure_compile...
File third_party/closure_compiler/externs/quick_unlock_private.js (right):

https://codereview.chromium.org/2104053003/diff/1/third_party/closure_compile...
third_party/closure_compiler/externs/quick_unlock_private.js:5: /**
@fileoverview Externs generated from namespace: quickUnlockPrivate */
How was this generated? Normally we run:

python ./tools/json_schema_compiler/compiler.py  -g externs
chrome/common/extensions/api/quick_unlock_private.idl >
third_party/closure_compiler/externs/quick_unlock_private.js 

which generates a different header...

[jdufault, 2016-06-28 22:36:43]

https://codereview.chromium.org/2104053003/diff/1/third_party/closure_compile...
File third_party/closure_compiler/externs/quick_unlock_private.js (right):

https://codereview.chromium.org/2104053003/diff/1/third_party/closure_compile...
third_party/closure_compiler/externs/quick_unlock_private.js:5: /**
@fileoverview Externs generated from namespace: quickUnlockPrivate */
On 2016/06/28 22:30:21, stevenjb wrote:
> How was this generated? Normally we run:
> 
> python ./tools/json_schema_compiler/compiler.py  -g externs
> chrome/common/extensions/api/quick_unlock_private.idl >
> third_party/closure_compiler/externs/quick_unlock_private.js 
> 
> which generates a different header...

I deleted this bit; I didn't see it in the other extern file I looked at, and it
seems like the message is not aimed for the codebase.

// This file was generated by:
//   ./tools/json_schema_compiler/compiler.py.
// NOTE: The format of types has changed. 'FooType' is now
//   'chrome.quickUnlockPrivate.FooType'.
// Please run the closure compiler before committing changes.
// See
https://chromium.googlesource.com/chromium/src/+/master/docs/closure_compilat...

I can add it back if you want. Otherwise running the snippet you gave gives an
identical file.

[stevenjb, 2016-06-28 22:40:58]

Yes, please re-add it. It's in all the more recently generated files.

At some point we need to re-generate all of them and remove part of that
comment, but for now this helps us track which have been generated recently.


On Tue, Jun 28, 2016 at 3:36 PM, <jdufault@chromium.org> wrote:

>
>
>
https://codereview.chromium.org/2104053003/diff/1/third_party/closure_compile...
> File third_party/closure_compiler/externs/quick_unlock_private.js
> (right):
>
>
>
https://codereview.chromium.org/2104053003/diff/1/third_party/closure_compile...
> third_party/closure_compiler/externs/quick_unlock_private.js:5: /**
> @fileoverview Externs generated from namespace: quickUnlockPrivate */
> On 2016/06/28 22:30:21, stevenjb wrote:
> > How was this generated? Normally we run:
> >
> > python ./tools/json_schema_compiler/compiler.py -g externs
> > chrome/common/extensions/api/quick_unlock_private.idl >
> > third_party/closure_compiler/externs/quick_unlock_private.js
> >
> > which generates a different header...
>
> I deleted this bit; I didn't see it in the other extern file I looked
> at, and it seems like the message is not aimed for the codebase.
>
> // This file was generated by:
> // ./tools/json_schema_compiler/compiler.py.
> // NOTE: The format of types has changed. 'FooType' is now
> // 'chrome.quickUnlockPrivate.FooType'.
> // Please run the closure compiler before committing changes.
> // See
>
>
https://chromium.googlesource.com/chromium/src/+/master/docs/closure_compilat...
>
> I can add it back if you want. Otherwise running the snippet you gave
> gives an identical file.
>
> https://codereview.chromium.org/2104053003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[jdufault, 2016-06-28 22:43:45]

On 2016/06/28 22:40:58, stevenjb wrote:
> Yes, please re-add it. It's in all the more recently generated files.
> 
> At some point we need to re-generate all of them and remove part of that
> comment, but for now this helps us track which have been generated recently.

Done.

[stevenjb, 2016-06-28 22:50:11]

lgtm

[jdufault, 2016-06-28 23:07:43]

The CQ bit was checked by jdufault@chromium.org

[commit-bot: I haz the power, 2016-06-28 23:09:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 01:51:50]

Description was changed from

==========
Add chrome.quickUnlockPrivate externs to closure

BUG=603217
==========

to

==========
Add chrome.quickUnlockPrivate externs to closure

BUG=603217
==========

[commit-bot: I haz the power, 2016-06-29 01:51:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-29 01:54:23]

Description was changed from

==========
Add chrome.quickUnlockPrivate externs to closure

BUG=603217
==========

to

==========
Add chrome.quickUnlockPrivate externs to closure

BUG=603217

Committed: https://crrev.com/c34468b226df93a22b9f196f87c440297b541f39
Cr-Commit-Position: refs/heads/master@{#402641}
==========

[commit-bot: I haz the power, 2016-06-29 01:54:24]

Patchset 2 (id:??) landed as
https://crrev.com/c34468b226df93a22b9f196f87c440297b541f39
Cr-Commit-Position: refs/heads/master@{#402641}