arc: bluetooth: Implement Gatt Server add/delete/start/stop service

components/arc/bluetooth/arc_bluetooth_bridge.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_ARC_BLUETOOTH_ARC_BLUETOOTH_BRIDGE_H_
 #define COMPONENTS_ARC_BLUETOOTH_ARC_BLUETOOTH_BRIDGE_H_
 
 #include <stdint.h>
 
 #include <map>
@@ skipping 22 matching lines @@
 class ArcBridgeService;
 
 class ArcBluetoothBridge
     : public ArcService,
       public InstanceHolder<mojom::BluetoothInstance>::Observer,
       public device::BluetoothAdapter::Observer,
       public device::BluetoothAdapterFactory::AdapterCallback,
       public device::BluetoothLocalGattService::Delegate,
       public mojom::BluetoothHost {
  public:
+  using GattStatusCallback = base::Callback<void(mojom::BluetoothGattStatus)>;
+  using GattReadCallback = base::Callback<void(mojom::BluetoothGattValuePtr)>;
+
   explicit ArcBluetoothBridge(ArcBridgeService* bridge_service);
   ~ArcBluetoothBridge() override;
 
   // Overridden from
   // InstanceHolder<mojom::BluetoothInstance>::Observer:
   void OnInstanceReady() override;
 
   void OnAdapterInitialized(scoped_refptr<device::BluetoothAdapter> adapter);
 
   // Overridden from device::BluetoothAdadpter::Observer
@@ skipping 132 matching lines @@
   // Bluetooth Mojo host interface - Bluetooth Gatt Client functions
   void StartLEScan() override;
   void StopLEScan() override;
   void ConnectLEDevice(mojom::BluetoothAddressPtr remote_addr) override;
   void DisconnectLEDevice(mojom::BluetoothAddressPtr remote_addr) override;
   void StartLEListen(const StartLEListenCallback& callback) override;
   void StopLEListen(const StopLEListenCallback& callback) override;
   void SearchService(mojom::BluetoothAddressPtr remote_addr) override;
 
   int ConvertGattIdentifierToId(const std::string identifier) const;
-  template <class T>
+  template <class RemoteGattObjectT>

[rkc, 2016/07/16 00:37:29]

Gatt Objects are collectively called Attributes. Why do we want to create a term
when one already exists?
Also, the T is redundant. We typically use T in a template typename to denote an
object of any arbitrary type (which is not the case here).

[rkc, 2016/07/18 21:48:16]

Unaddressed?

Please rename "GattObject" and similar names to "Attribute" or similar.

[puthik_chromium, 2016/07/18 22:45:23]

Missed this comment.
Done

   mojom::BluetoothGattDBElementPtr CreateGattDBElement(
       const mojom::BluetoothGattDBAttributeType type,
-      const T* GattObject) const;
+      const RemoteGattObjectT* GattObject) const;
   void GetGattDB(mojom::BluetoothAddressPtr remote_addr) override;
   void ReadGattCharacteristic(
       mojom::BluetoothAddressPtr remote_addr,
       mojom::BluetoothGattServiceIDPtr service_id,
       mojom::BluetoothGattIDPtr char_id,
       const ReadGattCharacteristicCallback& callback) override;
   void WriteGattCharacteristic(
       mojom::BluetoothAddressPtr remote_addr,
       mojom::BluetoothGattServiceIDPtr service_id,
       mojom::BluetoothGattIDPtr char_id,
@@ skipping 97 matching lines @@
                            scoped_refptr<device::BluetoothAdvertisement> adv);
   void OnStartLEListenError(
       const StartLEListenCallback& callback,
       device::BluetoothAdvertisement::ErrorCode error_code);
 
   void OnStopLEListenDone(const StopLEListenCallback& callback);
   void OnStopLEListenError(
       const StopLEListenCallback& callback,
       device::BluetoothAdvertisement::ErrorCode error_code);
 
-  using GattReadCallback = base::Callback<void(mojom::BluetoothGattValuePtr)>;
+  void OnGattOperationDone(const GattStatusCallback& callback) const;
+  void OnGattOperationError(
+      const GattStatusCallback& callback,
+      device::BluetoothGattService::GattErrorCode error_code) const;
+
   void OnGattReadDone(const GattReadCallback& callback,
                       const std::vector<uint8_t>& result) const;
   void OnGattReadError(
       const GattReadCallback& callback,
       device::BluetoothGattService::GattErrorCode error_code) const;
 
-  using GattWriteCallback = base::Callback<void(mojom::BluetoothGattStatus)>;
-  void OnGattWriteDone(const GattWriteCallback& callback) const;
-  void OnGattWriteError(
-      const GattWriteCallback& callback,
-      device::BluetoothGattService::GattErrorCode error_code) const;
-
   void OnGattNotifyStartDone(
       const RegisterForGattNotificationCallback& callback,
       const std::string char_string_id,
       std::unique_ptr<device::BluetoothGattNotifySession> notify_session);
-  void OnGattNotifyStartError(
-      const RegisterForGattNotificationCallback& callback,
-      device::BluetoothGattService::GattErrorCode error_code) const;
-  void OnGattNotifyStopDone(
-      const DeregisterForGattNotificationCallback& callback) const;
 
  private:
   mojo::Array<mojom::BluetoothPropertyPtr> GetDeviceProperties(
       mojom::BluetoothPropertyType type,
       device::BluetoothDevice* device) const;
   mojo::Array<mojom::BluetoothPropertyPtr> GetAdapterProperties(
       mojom::BluetoothPropertyType type) const;
   mojo::Array<mojom::BluetoothAdvertisingDataPtr> GetAdvertisingData(
       device::BluetoothDevice* device) const;
 
   void SendCachedDevicesFound() const;
   bool HasBluetoothInstance() const;
   bool CheckBluetoothInstanceVersion(uint32_t version_need) const;
 
-  template <class T>
-  T* FindGattObjectFromUuid(const std::vector<T*> objs,
-                            const device::BluetoothUUID uuid) const;
+  template <class RemoteGattObjectT>
+  RemoteGattObjectT* FindGattObjectFromUuid(
+      const std::vector<RemoteGattObjectT*> objs,
+      const device::BluetoothUUID uuid) const;
   device::BluetoothRemoteGattCharacteristic* FindGattCharacteristic(
       mojom::BluetoothAddressPtr remote_addr,
       mojom::BluetoothGattServiceIDPtr service_id,
       mojom::BluetoothGattIDPtr char_id) const;
 
   device::BluetoothRemoteGattDescriptor* FindGattDescriptor(
       mojom::BluetoothAddressPtr remote_addr,
       mojom::BluetoothGattServiceIDPtr service_id,
       mojom::BluetoothGattIDPtr char_id,
       mojom::BluetoothGattIDPtr desc_id) const;
 
   // Propagates the list of paired device to Android.
   void SendCachedPairedDevices() const;
 
+  template <class LocalGattObjectT>
+  int32_t CreateGattAttributeHandle(LocalGattObjectT* gatt_obj);
+
   mojo::Binding<mojom::BluetoothHost> binding_;
 
   scoped_refptr<bluez::BluetoothAdapterBlueZ> bluetooth_adapter_;
   scoped_refptr<device::BluetoothAdvertisement> advertisment_;
   std::unique_ptr<device::BluetoothDiscoverySession> discovery_session_;
   std::map<std::string, std::unique_ptr<device::BluetoothGattNotifySession>>
       notification_session_;
+  // Map from android int handle to Chrome (BlueZ) string identifier.
+  std::map<int32_t, std::string> gatt_identifier_;
+  // Store last GattCharacteristic added to each GattService for GattServer.
+  std::map<int32_t, int32_t> last_characteristic_;
+  // Running number for handle to give to Android side.
+  int32_t gatt_server_obj_handle = 0;
 
   // WeakPtrFactory to use for callbacks.
   base::WeakPtrFactory<ArcBluetoothBridge> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ArcBluetoothBridge);
 };
 
 }  // namespace arc
 
 #endif  // COMPONENTS_ARC_BLUETOOTH_ARC_BLUETOOTH_BRIDGE_H_