arc: bluetooth: Add Gatt server mojo API

components/arc/bluetooth/arc_bluetooth_bridge.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_ARC_BLUETOOTH_ARC_BLUETOOTH_BRIDGE_H_
 #define COMPONENTS_ARC_BLUETOOTH_ARC_BLUETOOTH_BRIDGE_H_
 
 #include <stdint.h>
 
 #include <map>
 #include <memory>
 #include <string>
 #include <vector>
 
 #include "base/callback.h"
 #include "components/arc/arc_bridge_service.h"
 #include "components/arc/arc_service.h"
 #include "components/arc/common/bluetooth.mojom.h"
 #include "components/arc/instance_holder.h"
 #include "device/bluetooth/bluetooth_adapter.h"
 #include "device/bluetooth/bluetooth_adapter_factory.h"
 #include "device/bluetooth/bluetooth_device.h"
 #include "device/bluetooth/bluetooth_discovery_session.h"
+#include "device/bluetooth/bluetooth_local_gatt_service.h"
 #include "device/bluetooth/bluetooth_remote_gatt_characteristic.h"
 #include "device/bluetooth/bluetooth_remote_gatt_descriptor.h"
 #include "device/bluetooth/bluetooth_remote_gatt_service.h"
 #include "device/bluetooth/bluez/bluetooth_adapter_bluez.h"
 #include "mojo/public/cpp/bindings/binding.h"
 
 namespace arc {
 
 class ArcBridgeService;
 
 class ArcBluetoothBridge
     : public ArcService,
       public InstanceHolder<mojom::BluetoothInstance>::Observer,
       public device::BluetoothAdapter::Observer,
       public device::BluetoothAdapterFactory::AdapterCallback,
+      public device::BluetoothLocalGattService::Delegate,
       public mojom::BluetoothHost {
  public:
   explicit ArcBluetoothBridge(ArcBridgeService* bridge_service);
   ~ArcBluetoothBridge() override;
 
   // Overridden from
   // InstanceHolder<mojom::BluetoothInstance>::Observer:
   void OnInstanceReady() override;
 
   void OnAdapterInitialized(scoped_refptr<device::BluetoothAdapter> adapter);
@@ skipping 59 matching lines @@
   void GattCharacteristicValueChanged(
       device::BluetoothAdapter* adapter,
       device::BluetoothRemoteGattCharacteristic* characteristic,
       const std::vector<uint8_t>& value) override;
 
   void GattDescriptorValueChanged(
       device::BluetoothAdapter* adapter,
       device::BluetoothRemoteGattDescriptor* descriptor,
       const std::vector<uint8_t>& value) override;
 
+  // Overridden from device::BluetoothLocalGattService::Delegate
+  void OnCharacteristicReadRequest(
+      const device::BluetoothDevice* device,
+      const device::BluetoothLocalGattCharacteristic* characteristic,
+      int offset,
+      const ValueCallback& callback,
+      const ErrorCallback& error_callback) override;
+
+  void OnCharacteristicWriteRequest(
+      const device::BluetoothDevice* device,
+      const device::BluetoothLocalGattCharacteristic* characteristic,
+      const std::vector<uint8_t>& value,
+      int offset,
+      const base::Closure& callback,
+      const ErrorCallback& error_callback) override;
+
+  void OnDescriptorReadRequest(
+      const device::BluetoothDevice* device,
+      const device::BluetoothLocalGattDescriptor* descriptor,
+      int offset,
+      const ValueCallback& callback,
+      const ErrorCallback& error_callback) override;
+
+  void OnDescriptorWriteRequest(
+      const device::BluetoothDevice* device,
+      const device::BluetoothLocalGattDescriptor* descriptor,
+      const std::vector<uint8_t>& value,
+      int offset,
+      const base::Closure& callback,
+      const ErrorCallback& error_callback) override;
+
+  void OnNotificationsStart(
+      const device::BluetoothDevice* device,
+      const device::BluetoothLocalGattCharacteristic* characteristic) override;
+
+  void OnNotificationsStop(
+      const device::BluetoothDevice* device,
+      const device::BluetoothLocalGattCharacteristic* characteristic) override;
+
   // Bluetooth Mojo host interface
   void EnableAdapter(const EnableAdapterCallback& callback) override;
   void DisableAdapter(const DisableAdapterCallback& callback) override;
 
   void GetAdapterProperty(mojom::BluetoothPropertyType type) override;
   void SetAdapterProperty(mojom::BluetoothPropertyPtr property) override;
 
   void GetRemoteDeviceProperty(mojom::BluetoothAddressPtr remote_addr,
                                mojom::BluetoothPropertyType type) override;
   void SetRemoteDeviceProperty(mojom::BluetoothAddressPtr remote_addr,
@@ skipping 57 matching lines @@
       mojom::BluetoothGattIDPtr char_id,
       const RegisterForGattNotificationCallback& callback) override;
   void DeregisterForGattNotification(
       mojom::BluetoothAddressPtr remote_addr,
       mojom::BluetoothGattServiceIDPtr service_id,
       mojom::BluetoothGattIDPtr char_id,
       const DeregisterForGattNotificationCallback& callback) override;
   void ReadRemoteRssi(mojom::BluetoothAddressPtr remote_addr,
                       const ReadRemoteRssiCallback& callback) override;
 
+  // Bluetooth Mojo host interface - Bluetooth Gatt Server functions
+  // Create a new service. Chrome will create an integer service handle based on
+  // that BlueZ identifier that will pass back to Android in the callback.
+  // num_handles: number of handle for characteristic / descriptor that will be
+  //              created in this service
+  void AddService(mojom::BluetoothGattServiceIDPtr service_id,
+                  int32_t num_handles,
+                  const AddServiceCallback& callback) override;
+  // Add a characteristic to a service and pass the characteristic handle back.
+  void AddCharacteristic(int32_t service_handle,
+                         mojom::BluetoothUUIDPtr uuid,
+                         int32_t properties,
+                         int32_t permissions,
+                         const AddCharacteristicCallback& callback) override;
+  // Add a descriptor to a given service and pass the descriptor handle back.
+  void AddDescriptor(int32_t service_handle,
+                     mojom::BluetoothUUIDPtr uuid,
+                     int32_t permissions,
+                     const AddDescriptorCallback& callback) override;
+  // Starts a local service
+  void StartService(int32_t service_handle,
+                    const StartServiceCallback& callback) override;
+  // Stops a local service
+  void StopService(int32_t service_handle,
+                   const StopServiceCallback& callback) override;
+  // Delete a local service
+  void DeleteService(int32_t service_handle,
+                     const DeleteServiceCallback& callback) override;
+  // Send value indication to a remote device
+  void SendIndication(int32_t attribute_handle,
+                      mojom::BluetoothAddressPtr address,
+                      bool confirm,
+                      mojo::Array<uint8_t> value,
+                      const SendIndicationCallback& callback) override;
+  // Send a response to a read/write operation

[palmer, 2016/07/16 00:21:04]

It's much better for comments to be complete, punctuated sentences that describe
the purpose of the arguments.

[puthik_chromium, 2016/07/18 21:27:39]

The comment is copy from Android code.
https://source.android.com/devices/halref/bt__gatt__server_8h_source.html

[Luis Héctor Chávez, 2016/07/19 01:26:02]

You can still improve the comments. Also, it would be beneficial to also include
a link to that document as part of the comments.

[puthik_chromium, 2016/07/19 22:21:22]

Link added

+  void SendResponse(int32_t trans_id,
+                    int32_t status,
+                    mojo::Array<uint8_t> value,
+                    const SendResponseCallback& callback) override;
+
   // Chrome observer callbacks
   void OnPoweredOn(
       const base::Callback<void(mojom::BluetoothAdapterState)>& callback) const;
   void OnPoweredOff(
       const base::Callback<void(mojom::BluetoothAdapterState)>& callback) const;
   void OnPoweredError(
       const base::Callback<void(mojom::BluetoothAdapterState)>& callback) const;
   void OnDiscoveryStarted(
       std::unique_ptr<device::BluetoothDiscoverySession> session);
   void OnDiscoveryStopped();
@@ skipping 90 matching lines @@
 
   // WeakPtrFactory to use for callbacks.
   base::WeakPtrFactory<ArcBluetoothBridge> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ArcBluetoothBridge);
 };
 
 }  // namespace arc
 
 #endif  // COMPONENTS_ARC_BLUETOOTH_ARC_BLUETOOTH_BRIDGE_H_