arc: bluetooth: Add Gatt server mojo API

components/arc/common/bluetooth.mojom

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 module arc.mojom;
 
 [Extensible]
 enum BluetoothAdapterState {
   OFF = 0,
   ON
@@ skipping 269 matching lines @@
       BluetoothGattID char_id)
       => (BluetoothGattStatus status);
   [MinVersion=1] DeregisterForGattNotification@27(
       BluetoothAddress remote_addr,
       BluetoothGattServiceID service_id,
       BluetoothGattID char_id)
       => (BluetoothGattStatus status);
   [MinVersion=1] ReadRemoteRssi@28(BluetoothAddress remote_addr)
       => (int32 rssi);
 
+  // Bluetooth Gatt Server functions
+  // TODO connect
+  [MinVersion=3] AddService@29(BluetoothGattServiceID service_id,
+                               int32 num_handles)

[rkc, 2016/06/29 21:54:17]

What is num_handles? Is this the handles of the included service? or?

Please add documentation to each of these functions clarifying what they do at
some location. Either here, or the header file.

[puthik_chromium, 2016/07/01 21:12:42]

Added at the header file.

+      => (int32 service_handle);
+  [MinVersion=3] AddCharacteristic@30(int32 service_handle,
+                                      BluetoothUUID uuid,
+                                      int32 properties,
+                                      int32 permissions)
+      => (int32 characteristic_handle);
+  [MinVersion=3] AddDescriptor@31(int32 service_handle,
+                                  BluetoothUUID uuid,
+                                  int32 permissions)
+      => (int32 descriptor_handle);
+  [MinVersion=3] StartService@32(int32 service_handle, int32 transport)

[rkc, 2016/06/29 21:54:17]

What is transport here?

[Eric Caruso, 2016/06/30 23:19:09]

It looks like this is BR/EDR, LE, etc.

I refactored the transport type so we have an enum for this in
device/bluetooth/bluetooth_common.h. Why don't we use the mojo DeviceType, which
gets typemapped to one of these?

[puthik_chromium, 2016/07/01 21:12:42]

Done.

+      => (BluetoothGattStatus status);
+  [MinVersion=3] StopService@33(int32 service_handle)
+      => (BluetoothGattStatus status);
+  [MinVersion=3] DeleteService@34(int32 service_handle)
+      => (BluetoothGattStatus status);
+  [MinVersion=3] SendIndication@35(int32 attribute_handle,

[rkc, 2016/06/29 21:54:17]

Should this be called SendNotification? The Android Java API uses the word
notify and the argument confirm.

Also, why is confirm an int32?

[Eric Caruso, 2016/06/30 23:19:09]

http://androidxref.com/6.0.1_r10/xref/hardware/libhardware/include/hardware/b...

Looks like this is libhardware's term for this function.

[puthik_chromium, 2016/07/01 21:12:42]

It's int32 in Android HAL, but the upper Java layer in Android is a boolean.
Boolean make more sense here so I change it to that.

+                                   BluetoothAddress address,
+                                   int32 confirm,
+                                   array<uint8> value)
+      => (BluetoothGattStatus status);
+  [MinVersion=3] SendResponse@36(int32 trans_id,
+                                 int32 status,
+                                 array<uint8> value)
+      => (BluetoothGattStatus status);
+
 };
 
 interface BluetoothInstance {
   Init@0(BluetoothHost host_ptr);
 
   OnAdapterProperties@1(BluetoothStatus status,
                         array<BluetoothProperty> properties);
   OnRemoteDeviceProperties@2(BluetoothStatus status,
                              BluetoothAddress address,
                              array<BluetoothProperty> properties);
@@ skipping 19 matching lines @@
   [MinVersion=1] OnServicesRemoved@11(BluetoothAddress remote_addr,
                                       uint16 start_handle,
                                       uint16 end_handle);
   [MinVersion=1] OnServicesAdded@12(BluetoothAddress remote_addr,
                                     array<BluetoothGattDBElement> db);
   [MinVersion=2] OnGattNotify@13(BluetoothAddress remote_addr,
                                  BluetoothGattServiceID service_id,
                                  BluetoothGattID char_id,
                                  bool is_notify,
                                  array<uint8> value);
+
+  // Bluetooth Gatt Server functions
+  [MinVersion=3] RequestGattRead@14(BluetoothAddress address,
+                                    int32 transaction_id,
+                                    int32 attribute_handle,
+                                    int32 offset,
+                                    bool is_long);
+  [MinVersion=3] RequestGattWrite@15(BluetoothAddress address,
+                                     int32 transaction_id,
+                                     int32 attribute_handle,
+                                     int32 offset,
+                                     array<uint8> value);
 };