chrome/test/data/webui/md_history/history_overflow_menu_test.js - Issue 2104013004: MD WebUI: Reimplement cr-shared-menu using iron-dropdown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/webui/md_history/history_overflow_menu_test.js

Issue 2104013004: MD WebUI: Reimplement cr-shared-menu using iron-dropdown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/webui/cr_elements/cr_shared_menu_tests.js ('k') | ui/webui/resources/cr_elements/cr_shared_menu/compiled_resources2.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/webui/md_history/history_overflow_menu_test.js

diff --git a/chrome/test/data/webui/md_history/history_overflow_menu_test.js b/chrome/test/data/webui/md_history/history_overflow_menu_test.js

index 01836a7f3545f911d201889063cd9a60e240be06..b7ca2eebe61bad2ebc20bee02a3336abf227fce1 100644

--- a/chrome/test/data/webui/md_history/history_overflow_menu_test.js

+++ b/chrome/test/data/webui/md_history/history_overflow_menu_test.js

@@ -61,15 +61,6 @@ cr.define('md_history.history_overflow_menu_test', function() {

element.$.sharedMenu.lastAnchor_);

});

- test('keyboard input for closing menu', function() {

- // Test that pressing escape on the document closes the menu. In the

- // actual page, it will take two presses to close the menu due to focus.

- // TODO(yingran): Fix this behavior to only require one key press.

- element.toggleMenu_(MENU_EVENT);

- MockInteractions.pressAndReleaseKeyOn(document.body, 27);

- assertEquals(false, element.$.sharedMenu.menuOpen);

- });

teardown(function() {

element.$.sharedMenu.lastAnchor_ = null;

});