Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2104013002: buildbucket: use OptionalLogin if service account is not passed (Closed)

Created:
4 years, 5 months ago by nodir
Modified:
4 years, 5 months ago
Reviewers:
Vadim Sh.
CC:
chanli
Base URL:
https://chromium.googlesource.com/external/github.com/luci/luci-go@master
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

buildbucket: use OptionalLogin if service account is not passed Last change to this code broke builders that do not specify service account: https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_variable/builds/251/steps/buildbucket.get/logs/stdio R=vadimsh@chromium.org BUG=624040 Committed: https://github.com/luci/luci-go/commit/55099ee0ec9f8a9b53bbd90600946d100cb76cac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M client/cmd/buildbucket/base_command.go View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
nodir
PTAL
4 years, 5 months ago (2016-06-28 18:20:01 UTC) #1
Vadim Sh.
lgtm
4 years, 5 months ago (2016-06-28 18:22:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104013002/1
4 years, 5 months ago (2016-06-28 18:22:46 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 18:35:20 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/55099ee0ec9f8a9b53bbd90600946d100cb76cac

Powered by Google App Engine
This is Rietveld 408576698