Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2104003003: Update Build and Running documentation. (Closed)

Created:
4 years, 5 months ago by Sriram
Modified:
4 years, 5 months ago
Reviewers:
nyquist, Kevin M
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Build and Running documentation. - Added links to Android build with information on how to pull Android parts of Chromium repo. - Reordered running instruction to follow the order in which one would use. - Added infomration on the underlying adb command to use instead of build scripts. - Added information on running the Blimp client in an Emulator. BUG= Committed: https://crrev.com/0b6a45f4dd3b47a1f3214d53cd5934aa62b891f5 Cr-Commit-Position: refs/heads/master@{#403255}

Patch Set 1 #

Total comments: 18

Patch Set 2 : Updated based on CR comments #

Total comments: 6

Patch Set 3 : Addressing Kevin's CR comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -40 lines) Patch
M blimp/docs/build.md View 1 2 chunks +11 lines, -0 lines 0 comments Download
M blimp/docs/running.md View 1 2 4 chunks +90 lines, -40 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Sriram
kmarshall@chromium.org: Please review changes in nyquist@chromium.org: Please review changes in
4 years, 5 months ago (2016-06-28 18:35:49 UTC) #2
Kevin M
https://codereview.chromium.org/2104003003/diff/1/blimp/docs/build.md File blimp/docs/build.md (right): https://codereview.chromium.org/2104003003/diff/1/blimp/docs/build.md#newcode4 blimp/docs/build.md:4: If you want to build the Android client then ...
4 years, 5 months ago (2016-06-28 22:31:53 UTC) #3
Sriram
https://codereview.chromium.org/2104003003/diff/1/blimp/docs/build.md File blimp/docs/build.md (right): https://codereview.chromium.org/2104003003/diff/1/blimp/docs/build.md#newcode4 blimp/docs/build.md:4: If you want to build the Android client then ...
4 years, 5 months ago (2016-06-28 23:22:38 UTC) #4
Kevin M
lgtm % nits https://codereview.chromium.org/2104003003/diff/20001/blimp/docs/running.md File blimp/docs/running.md (right): https://codereview.chromium.org/2104003003/diff/20001/blimp/docs/running.md#newcode60 blimp/docs/running.md:60: The engine sends partially rendered content ...
4 years, 5 months ago (2016-06-29 20:23:58 UTC) #5
Sriram
https://codereview.chromium.org/2104003003/diff/20001/blimp/docs/running.md File blimp/docs/running.md (right): https://codereview.chromium.org/2104003003/diff/20001/blimp/docs/running.md#newcode60 blimp/docs/running.md:60: The engine sends partially rendered content to the client. ...
4 years, 5 months ago (2016-06-30 19:00:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104003003/40001
4 years, 5 months ago (2016-06-30 19:01:43 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-30 19:42:41 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 19:42:52 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 19:46:03 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0b6a45f4dd3b47a1f3214d53cd5934aa62b891f5
Cr-Commit-Position: refs/heads/master@{#403255}

Powered by Google App Engine
This is Rietveld 408576698