|
|
Descriptiongpu, cmaa: blend color like bilinear filter
This CL fixes two points
* blend color like bilinear filter. Current implementation is strange hackish
blend.
* Revert blurCoeff to the original value as the comments explain. The value
might be changed to make hackish blend look good. After revert, CMAA looks
much more similar to MSAA
BUG=535198
TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders"
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
Committed: https://crrev.com/679dd4bf7fd35ac9bbc30d33e908f88f93e28d95
Cr-Commit-Position: refs/heads/master@{#402788}
Patch Set 1 #
Messages
Total messages: 16 (8 generated)
Description was changed from ========== gpu, cmaa: blend color like bilinear filter This CL fixes two points * blend color like bilinear filter. Current implementation is strange hackish blend. * Revert blurCoeff to the original value as the comments explain. The value might be changed to make hackish blend look good. After revert, CMAA looks much more similar to MSAA BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" ========== to ========== gpu, cmaa: blend color like bilinear filter This CL fixes two points * blend color like bilinear filter. Current implementation is strange hackish blend. * Revert blurCoeff to the original value as the comments explain. The value might be changed to make hackish blend look good. After revert, CMAA looks much more similar to MSAA BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
dongseong.hwang@intel.com changed reviewers: + adrian.belgun@intel.com, piman@chromium.org
piman@ could you review? It's the 5th CL of https://bugs.chromium.org/p/chromium/issues/detail?id=535198#c16
lgtm
lgtm
The CQ bit was checked by dongseong.hwang@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Description was changed from ========== gpu, cmaa: blend color like bilinear filter This CL fixes two points * blend color like bilinear filter. Current implementation is strange hackish blend. * Revert blurCoeff to the original value as the comments explain. The value might be changed to make hackish blend look good. After revert, CMAA looks much more similar to MSAA BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== gpu, cmaa: blend color like bilinear filter This CL fixes two points * blend color like bilinear filter. Current implementation is strange hackish blend. * Revert blurCoeff to the original value as the comments explain. The value might be changed to make hackish blend look good. After revert, CMAA looks much more similar to MSAA BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel ==========
The CQ bit was checked by dongseong.hwang@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== gpu, cmaa: blend color like bilinear filter This CL fixes two points * blend color like bilinear filter. Current implementation is strange hackish blend. * Revert blurCoeff to the original value as the comments explain. The value might be changed to make hackish blend look good. After revert, CMAA looks much more similar to MSAA BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel ========== to ========== gpu, cmaa: blend color like bilinear filter This CL fixes two points * blend color like bilinear filter. Current implementation is strange hackish blend. * Revert blurCoeff to the original value as the comments explain. The value might be changed to make hackish blend look good. After revert, CMAA looks much more similar to MSAA BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== gpu, cmaa: blend color like bilinear filter This CL fixes two points * blend color like bilinear filter. Current implementation is strange hackish blend. * Revert blurCoeff to the original value as the comments explain. The value might be changed to make hackish blend look good. After revert, CMAA looks much more similar to MSAA BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel ========== to ========== gpu, cmaa: blend color like bilinear filter This CL fixes two points * blend color like bilinear filter. Current implementation is strange hackish blend. * Revert blurCoeff to the original value as the comments explain. The value might be changed to make hackish blend look good. After revert, CMAA looks much more similar to MSAA BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/679dd4bf7fd35ac9bbc30d33e908f88f93e28d95 Cr-Commit-Position: refs/heads/master@{#402788} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/679dd4bf7fd35ac9bbc30d33e908f88f93e28d95 Cr-Commit-Position: refs/heads/master@{#402788} |