Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2104003002: gpu, cmaa: blend color like bilinear filter (Closed)

Created:
4 years, 5 months ago by dshwang
Modified:
4 years, 5 months ago
Reviewers:
adrian.belgun, piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu, cmaa: blend color like bilinear filter This CL fixes two points * blend color like bilinear filter. Current implementation is strange hackish blend. * Revert blurCoeff to the original value as the comments explain. The value might be changed to make hackish blend look good. After revert, CMAA looks much more similar to MSAA BUG=535198 TEST=Run a WebGL app with Chrome started with "--enable-cmaa-shaders" CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/679dd4bf7fd35ac9bbc30d33e908f88f93e28d95 Cr-Commit-Position: refs/heads/master@{#402788}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -19 lines) Patch
M gpu/command_buffer/service/gles2_cmd_apply_framebuffer_attachment_cmaa_intel.cc View 5 chunks +17 lines, -19 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
dshwang
piman@ could you review? It's the 5th CL of https://bugs.chromium.org/p/chromium/issues/detail?id=535198#c16
4 years, 5 months ago (2016-06-28 18:17:17 UTC) #3
piman
lgtm
4 years, 5 months ago (2016-06-28 21:11:10 UTC) #4
adrian.belgun
lgtm
4 years, 5 months ago (2016-06-29 10:35:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104003002/1
4 years, 5 months ago (2016-06-29 12:12:37 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/252262)
4 years, 5 months ago (2016-06-29 12:40:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104003002/1
4 years, 5 months ago (2016-06-29 12:54:09 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 13:21:26 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 13:24:37 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/679dd4bf7fd35ac9bbc30d33e908f88f93e28d95
Cr-Commit-Position: refs/heads/master@{#402788}

Powered by Google App Engine
This is Rietveld 408576698