Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 21040: Experimental: handle single-entry basic blocks as a special case.... (Closed)

Created:
11 years, 10 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Experimental: handle single-entry basic blocks as a special case. Also, clean up fast switch jump tables. If basic block entry labels are forward-only and they are bound with exactly one incoming CFG edge (either a live frame and no jumps or branches, or no live frame and a single jump or branch) then they can be treated specially. The body of the block is compiled with the single reaching frame, with no extra code emitted. The fast-case switch statements are cleaned up to use raw labels rather than jump targets, because they do not fit the jump target abstraction very well. Committed: http://code.google.com/p/v8/source/detail?r=1221

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -140 lines) Patch
M src/codegen.cc View 3 chunks +18 lines, -23 lines 0 comments Download
M src/codegen-ia32.h View 1 chunk +5 lines, -5 lines 0 comments Download
M src/codegen-ia32.cc View 17 chunks +69 lines, -67 lines 0 comments Download
M src/jump-target.h View 2 chunks +10 lines, -14 lines 0 comments Download
M src/jump-target-ia32.cc View 8 chunks +87 lines, -31 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
11 years, 10 months ago (2009-02-04 10:07:49 UTC) #1
Mads Ager (chromium)
11 years, 10 months ago (2009-02-04 10:37:56 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698