Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2103983003: Revert "[wasm] Complete separation of compilation and instantiation" (Closed)

Created:
4 years, 5 months ago by Mircea Trofin
Modified:
4 years, 5 months ago
Reviewers:
bradnelson, bradn, danno
CC:
v8-reviews_googlegroups.com, gdeepti
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "[wasm] Complete separation of compilation and instantiation" This reverts commit 0c7ee92783eaadbd62fd37f7ae1035c4778e9c7a. BUG= Committed: https://crrev.com/1eb1dfabe4bf8ff934047335dfebafb8f0dfc550 Cr-Commit-Position: refs/heads/master@{#37351}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+338 lines, -636 lines) Patch
M src/compiler/wasm-compiler.h View 1 chunk +6 lines, -8 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 6 chunks +37 lines, -56 lines 0 comments Download
M src/objects.h View 2 chunks +0 lines, -7 lines 0 comments Download
M src/objects-inl.h View 2 chunks +1 line, -16 lines 0 comments Download
M src/signature.h View 3 chunks +2 lines, -4 lines 0 comments Download
M src/wasm/wasm-js.cc View 1 chunk +3 lines, -8 lines 0 comments Download
M src/wasm/wasm-module.h View 1 chunk +3 lines, -5 lines 0 comments Download
M src/wasm/wasm-module.cc View 15 chunks +280 lines, -525 lines 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Mircea Trofin
4 years, 5 months ago (2016-06-28 21:28:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103983003/1
4 years, 5 months ago (2016-06-28 21:31:10 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 5 months ago (2016-06-28 21:31:12 UTC) #7
Mircea Trofin
Pulling out and investigating relationship with grow memory.
4 years, 5 months ago (2016-06-28 21:39:58 UTC) #9
bradnelson
lgtm
4 years, 5 months ago (2016-06-28 21:40:31 UTC) #10
bradnelson
lgtm
4 years, 5 months ago (2016-06-28 21:40:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103983003/1
4 years, 5 months ago (2016-06-28 21:40:48 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 21:54:33 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 21:55:44 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1eb1dfabe4bf8ff934047335dfebafb8f0dfc550
Cr-Commit-Position: refs/heads/master@{#37351}

Powered by Google App Engine
This is Rietveld 408576698