Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 2103953006: Mobile: Restore painted content for fullscreen video. (Closed)

Created:
4 years, 5 months ago by sandersd (OOO until July 31)
Modified:
4 years, 5 months ago
Reviewers:
watk, *foolip
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mobile: Restore painted content for fullscreen video. It is no longer necessary to disable the background-image and border properties for fullscreen video on Android because commit 014e89fdbe83fd895898331249f9bba28cc71130 does this in a non-exposed way. (Actually rendering such content is still in progress.) BUG=618753 Committed: https://crrev.com/0fbe2117175d7766761489fe60da97a4a34cdbf2 Cr-Commit-Position: refs/heads/master@{#404727}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M third_party/WebKit/Source/core/css/fullscreenAndroid.css View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
sandersd (OOO until July 31)
4 years, 5 months ago (2016-06-29 19:04:59 UTC) #3
foolip
lgtm
4 years, 5 months ago (2016-06-30 10:57:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103953006/1
4 years, 5 months ago (2016-06-30 18:16:34 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/248649)
4 years, 5 months ago (2016-06-30 19:20:21 UTC) #8
watk
lgtm
4 years, 5 months ago (2016-07-11 19:25:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103953006/1
4 years, 5 months ago (2016-07-11 19:27:52 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 20:51:32 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 20:51:39 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 20:53:53 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0fbe2117175d7766761489fe60da97a4a34cdbf2
Cr-Commit-Position: refs/heads/master@{#404727}

Powered by Google App Engine
This is Rietveld 408576698