Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 2103903004: fix fuzz test that exceeds numeric limit (Closed)

Created:
4 years, 5 months ago by caryclark
Modified:
4 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix fuzz test that exceeds numeric limit The extreme values here exceed an internal test that expects computed numbers to be less than MAX_FLT. Use MAX_DBL instead. R=mmoroz@chromium.org TBR=reed@google.com BUG=624346 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2103903004 Committed: https://skia.googlesource.com/skia/+/343382e3acc8369f7bd4328e7c807255b5776fe5

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -2 lines) Patch
M src/pathops/SkOpSegment.cpp View 2 chunks +6 lines, -1 line 1 comment Download
M src/pathops/SkPathOpsTSect.h View 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsOpTest.cpp View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103903004/1
4 years, 5 months ago (2016-06-29 14:41:39 UTC) #3
caryclark
4 years, 5 months ago (2016-06-29 14:41:39 UTC) #4
mmoroz
LGTM Thought I'm not too experienced with Skia, adding mbarbella@ just a fyi. https://codereview.chromium.org/2103903004/diff/1/src/pathops/SkOpSegment.cpp File ...
4 years, 5 months ago (2016-06-29 14:52:35 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-29 15:13:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103903004/1
4 years, 5 months ago (2016-06-29 15:17:41 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/343382e3acc8369f7bd4328e7c807255b5776fe5
4 years, 5 months ago (2016-06-29 15:18:42 UTC) #12
Martin Barbella
4 years, 5 months ago (2016-06-29 16:40:24 UTC) #13
Message was sent while issue was closed.
LGTM. Thanks for the fix.

Powered by Google App Engine
This is Rietveld 408576698