Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1054)

Unified Diff: net/ssl/ssl_platform_key_task_runner.h

Issue 2103883004: Remove dependency of SSLPlatformKeyTaskRunner on single-threaded SequencedWorkerPool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@a2_hook
Patch Set: fix fwd-decls Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/ssl/ssl_platform_key_task_runner.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/ssl/ssl_platform_key_task_runner.h
diff --git a/net/ssl/ssl_platform_key_task_runner.h b/net/ssl/ssl_platform_key_task_runner.h
index 0c9b124f1fa3f891ae15f6f0c38d30aee0e45b85..cb6b4b4c28c98f7b89aa795b36fee9a3a35bdfed 100644
--- a/net/ssl/ssl_platform_key_task_runner.h
+++ b/net/ssl/ssl_platform_key_task_runner.h
@@ -6,27 +6,32 @@
#define NET_SSL_SSL_PLATFORM_KEY_TASK_RUNNER_H_
#include "base/macros.h"
-#include "base/threading/sequenced_worker_pool.h"
+#include "base/memory/ref_counted.h"
+#include "base/threading/thread.h"
+
+namespace base {
+class SingleThreadTaskRunner;
+}
namespace net {
-// Serialize all the private key operations on a single background
-// thread to avoid problems with buggy smartcards.
+// Serialize all the private key operations on a single background thread to
+// avoid problems with buggy smartcards. Its underlying Thread is non-joinable
+// and as such provides TaskShutdownBehavior::CONTINUE_ON_SHUTDOWN semantics.
class SSLPlatformKeyTaskRunner {
public:
SSLPlatformKeyTaskRunner();
~SSLPlatformKeyTaskRunner();
- scoped_refptr<base::SequencedTaskRunner> task_runner();
+ scoped_refptr<base::SingleThreadTaskRunner> task_runner();
private:
- scoped_refptr<base::SequencedWorkerPool> worker_pool_;
- scoped_refptr<base::SequencedTaskRunner> task_runner_;
+ base::Thread worker_thread_;
DISALLOW_COPY_AND_ASSIGN(SSLPlatformKeyTaskRunner);
};
-scoped_refptr<base::SequencedTaskRunner> GetSSLPlatformKeyTaskRunner();
+scoped_refptr<base::SingleThreadTaskRunner> GetSSLPlatformKeyTaskRunner();
} // namespace net
« no previous file with comments | « no previous file | net/ssl/ssl_platform_key_task_runner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698