Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: net/ssl/ssl_platform_key_task_runner.h

Issue 2103883004: Remove dependency of SSLPlatformKeyTaskRunner on single-threaded SequencedWorkerPool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@a2_hook
Patch Set: Use a non-joinable base::Thread. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_SSL_SSL_PLATFORM_KEY_TASK_RUNNER_H_ 5 #ifndef NET_SSL_SSL_PLATFORM_KEY_TASK_RUNNER_H_
6 #define NET_SSL_SSL_PLATFORM_KEY_TASK_RUNNER_H_ 6 #define NET_SSL_SSL_PLATFORM_KEY_TASK_RUNNER_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/threading/sequenced_worker_pool.h" 9 #include "base/memory/ref_counted.h"
10 #include "base/threading/thread.h"
11
12 namespace {
13 class SingleThreadTaskRunner;
Ryan Sleevi 2016/07/27 19:09:23 BUG: wrong namespace; should be base, but you've g
gab 2016/07/28 18:30:34 Oops, good eyes, done.
14 }
Ryan Sleevi 2016/07/27 19:09:23 STYLE: } // namespace base
gab 2016/07/28 18:30:34 I've been told (by danakj@) that for small fwd-dec
10 15
11 namespace net { 16 namespace net {
12 17
13 // Serialize all the private key operations on a single background 18 // Serialize all the private key operations on a single background thread to
14 // thread to avoid problems with buggy smartcards. 19 // avoid problems with buggy smartcards. Its underlying Thread is non-joinable
20 // and as such provides TaskShutdownBehavior::CONTINUE_ON_SHUTDOWN semantics.
15 class SSLPlatformKeyTaskRunner { 21 class SSLPlatformKeyTaskRunner {
16 public: 22 public:
17 SSLPlatformKeyTaskRunner(); 23 SSLPlatformKeyTaskRunner();
18 ~SSLPlatformKeyTaskRunner(); 24 ~SSLPlatformKeyTaskRunner();
19 25
20 scoped_refptr<base::SequencedTaskRunner> task_runner(); 26 scoped_refptr<base::SingleThreadTaskRunner> task_runner();
21 27
22 private: 28 private:
23 scoped_refptr<base::SequencedWorkerPool> worker_pool_; 29 base::Thread worker_thread_;
24 scoped_refptr<base::SequencedTaskRunner> task_runner_;
25 30
26 DISALLOW_COPY_AND_ASSIGN(SSLPlatformKeyTaskRunner); 31 DISALLOW_COPY_AND_ASSIGN(SSLPlatformKeyTaskRunner);
27 }; 32 };
28 33
29 scoped_refptr<base::SequencedTaskRunner> GetSSLPlatformKeyTaskRunner(); 34 scoped_refptr<base::SingleThreadTaskRunner> GetSSLPlatformKeyTaskRunner();
30 35
31 } // namespace net 36 } // namespace net
32 37
33 #endif // NET_SSL_SSL_PLATFORM_KEY_TASK_RUNNER_H_ 38 #endif // NET_SSL_SSL_PLATFORM_KEY_TASK_RUNNER_H_
OLDNEW
« no previous file with comments | « no previous file | net/ssl/ssl_platform_key_task_runner.cc » ('j') | net/ssl/threaded_ssl_private_key.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698