Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issue 2103863005: fix another pathops fuzz bug (Closed)

Created:
4 years, 5 months ago by caryclark
Modified:
4 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix another pathops fuzz bug Tunnel out the error case when the numerics create uncalculable angles. R=mmoroz@chromium.org TBR=reed@google.com BUG=624351 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2103863005 Committed: https://skia.googlesource.com/skia/+/aa7ceb62b51bfe1057c83b3475797ec7c82bc964

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -0 lines) Patch
M src/pathops/SkPathOpsCommon.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsOp.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/PathOpsOpTest.cpp View 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103863005/1
4 years, 5 months ago (2016-06-29 16:51:16 UTC) #3
caryclark
4 years, 5 months ago (2016-06-29 16:51:18 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-29 17:07:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103863005/1
4 years, 5 months ago (2016-06-29 17:45:04 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/aa7ceb62b51bfe1057c83b3475797ec7c82bc964
4 years, 5 months ago (2016-06-29 17:46:12 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-29 17:46:15 UTC) #11
mmoroz
4 years, 5 months ago (2016-06-29 18:57:11 UTC) #13
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698