Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4349)

Unified Diff: chrome/browser/chromeos/login/profile_auth_data_unittest.cc

Issue 2103863003: Make CanonicalCookie::Source() private. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@source
Patch Set: Merge Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/login/profile_auth_data.cc ('k') | ios/net/cookies/system_cookie_util_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/profile_auth_data_unittest.cc
diff --git a/chrome/browser/chromeos/login/profile_auth_data_unittest.cc b/chrome/browser/chromeos/login/profile_auth_data_unittest.cc
index e5fb43f60138848f882308daebc74ec4266703e9..a44540eb7fd40e31a943af8d66f89e3d9b33a77b 100644
--- a/chrome/browser/chromeos/login/profile_auth_data_unittest.cc
+++ b/chrome/browser/chromeos/login/profile_auth_data_unittest.cc
@@ -52,6 +52,7 @@ const char kCookieValue1[] = "value 1";
const char kCookieValue2[] = "value 2";
const char kGAIACookieDomain[] = "google.com";
const char kSAMLIdPCookieDomain[] = "example.com";
+const char kSAMLIdPCookieDomainWithWildcard[] = ".example.com";
const char kChannelIDServerIdentifier[] = "server";
@@ -174,16 +175,20 @@ void ProfileAuthDataTest::VerifyUserCookies(
const std::string& expected_gaia_cookie_value,
const std::string& expected_saml_idp_cookie_value) {
net::CookieList user_cookies = GetUserCookies();
- ASSERT_EQ(2u, user_cookies.size());
+ ASSERT_EQ(3u, user_cookies.size());
+
+ // Cookies are returned chronoligically, in the order they were set.
net::CanonicalCookie* cookie = &user_cookies[0];
- // kSAMLIdPCookieURL is returned first because it was created first, so has
- // the earliest creation date.
- EXPECT_EQ(GURL(kSAMLIdPCookieURL), cookie->Source());
EXPECT_EQ(kCookieName, cookie->Name());
EXPECT_EQ(expected_saml_idp_cookie_value, cookie->Value());
- EXPECT_EQ(kSAMLIdPCookieDomain, cookie->Domain());
+ EXPECT_EQ(kSAMLIdPCookieDomainWithWildcard, cookie->Domain());
+
cookie = &user_cookies[1];
- EXPECT_EQ(GURL(kGAIACookieURL), cookie->Source());
+ EXPECT_EQ(kCookieName, cookie->Name());
+ EXPECT_EQ(expected_saml_idp_cookie_value, cookie->Value());
+ EXPECT_EQ(kSAMLIdPCookieDomain, cookie->Domain());
+
+ cookie = &user_cookies[2];
EXPECT_EQ(kCookieName, cookie->Name());
EXPECT_EQ(expected_gaia_cookie_value, cookie->Value());
EXPECT_EQ(kGAIACookieDomain, cookie->Domain());
@@ -220,6 +225,12 @@ void ProfileAuthDataTest::PopulateBrowserContext(
run_loop_->Run();
cookies->SetCookieWithDetailsAsync(
+ GURL(kSAMLIdPCookieURL), kCookieName, cookie_value,
+ kSAMLIdPCookieDomainWithWildcard, std::string(), base::Time(),
+ base::Time(), base::Time(), true, false,
+ net::CookieSameSite::DEFAULT_MODE, false, net::COOKIE_PRIORITY_DEFAULT,
+ net::CookieStore::SetCookiesCallback());
+ cookies->SetCookieWithDetailsAsync(
GURL(kSAMLIdPCookieURL), kCookieName, cookie_value, std::string(),
std::string(), base::Time(), base::Time(), base::Time(), true, false,
net::CookieSameSite::DEFAULT_MODE, false, net::COOKIE_PRIORITY_DEFAULT,
« no previous file with comments | « chrome/browser/chromeos/login/profile_auth_data.cc ('k') | ios/net/cookies/system_cookie_util_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698