third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp - Issue 2103823002: Disallow raw pointers in CrossThreadCopier/threadSafeBind()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp

Issue 2103823002: Disallow raw pointers in CrossThreadCopier/threadSafeBind() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: bug fix. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp ('k') | third_party/WebKit/Source/platform/CrossThreadCopier.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp b/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp

index b1a943e899a08ae61d93964c57a4c087af99214f..5752f0b18251331200064dc8043ec77e88b3596e 100644

--- a/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp

@@ -115,14 +115,14 @@ void OfflineAudioDestinationHandler::startRendering()

if (!m_isRenderingStarted) {

m_isRenderingStarted = true;

m_renderThread->getWebTaskRunner()->postTask(BLINK_FROM_HERE,

- threadSafeBind(&OfflineAudioDestinationHandler::startOfflineRendering, this));

+ threadSafeBind(&OfflineAudioDestinationHandler::startOfflineRendering, wrapPassRefPtr(this)));

return;

}

// Rendering is already started, which implicitly means we resume the

// rendering by calling |doOfflineRendering| on the render thread.

m_renderThread->getWebTaskRunner()->postTask(BLINK_FROM_HERE,

- threadSafeBind(&OfflineAudioDestinationHandler::doOfflineRendering, this));

+ threadSafeBind(&OfflineAudioDestinationHandler::doOfflineRendering, wrapPassRefPtr(this)));

}

void OfflineAudioDestinationHandler::stopRendering()