third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.cpp - Issue 2103823002: Disallow raw pointers in CrossThreadCopier/threadSafeBind()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.cpp

Issue 2103823002: Disallow raw pointers in CrossThreadCopier/threadSafeBind() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: bug fix. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h ('k') | third_party/WebKit/Source/modules/fetch/DataConsumerTee.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.cpp b/third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.cpp

index f5834c2923b54b9be9c4a86bb86f7c49de0a6475..eb91aa8461a14f36ffed2407402d3d3c8aa38174 100644

--- a/third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.cpp

+++ b/third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.cpp

@@ -195,7 +195,7 @@ void DataConsumerHandleTestUtil::ReplayingHandle::Context::notify()

if (!m_client)

return;

ASSERT(m_readerThread);

- m_readerThread->getWebTaskRunner()->postTask(BLINK_FROM_HERE, threadSafeBind(&Context::notifyInternal, this));

+ m_readerThread->getWebTaskRunner()->postTask(BLINK_FROM_HERE, threadSafeBind(&Context::notifyInternal, wrapPassRefPtr(this)));

}

void DataConsumerHandleTestUtil::ReplayingHandle::Context::notifyInternal()