Disallow raw pointers in CrossThreadCopier/threadSafeBind()

third_party/WebKit/Source/platform/CrossThreadCopier.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 52 matching lines @@
 {
     return passed(response.copyData());
 }
 
 // Test CrossThreadCopier using static_assert.
 
 // Verify that ThreadSafeRefCounted objects get handled correctly.
 class CopierThreadSafeRefCountedTest : public ThreadSafeRefCounted<CopierThreadSafeRefCountedTest> {
 };
 
+// Add a generic specialization which will let's us verify that no other template matches.
+template<typename T> struct CrossThreadCopierBase<T, false> {
+    typedef int Type;
+};
+
 static_assert((std::is_same<
     PassRefPtr<CopierThreadSafeRefCountedTest>,
     CrossThreadCopier<PassRefPtr<CopierThreadSafeRefCountedTest>>::Type
     >::value),
-    "PassRefPtr test");
+    "PassRefPtr + ThreadSafeRefCounted should pass CrossThreadCopier");
 static_assert((std::is_same<
-    PassRefPtr<CopierThreadSafeRefCountedTest>,
+    RefPtr<CopierThreadSafeRefCountedTest>,
     CrossThreadCopier<RefPtr<CopierThreadSafeRefCountedTest>>::Type
     >::value),
-    "RefPtr test");
+    "RefPtr + ThreadSafeRefCounted should pass CrossThreadCopier");
 static_assert((std::is_same<
-    PassRefPtr<CopierThreadSafeRefCountedTest>,
+    int,
     CrossThreadCopier<CopierThreadSafeRefCountedTest*>::Type
     >::value),
-    "RawPointer test");
-
-
-// Add a generic specialization which will let's us verify that no other template matches.
-template<typename T> struct CrossThreadCopierBase<T, false, false> {
-    typedef int Type;
-};
+    "Raw pointer + ThreadSafeRefCounted should NOT pass CrossThreadCopier");
 
 // Verify that RefCounted objects only match our generic template which exposes Type as int.
 class CopierRefCountedTest : public RefCounted<CopierRefCountedTest> {
 };
 
 static_assert((std::is_same<
     int,
-    CrossThreadCopier<PassRefPtr<CopierRefCountedTest>>::Type
-    >::value),
-    "PassRefPtr<RefCountedTest> test");
-
-static_assert((std::is_same<
-    int,
-    CrossThreadCopier<RefPtr<CopierRefCountedTest>>::Type
-    >::value),
-    "RefPtr<RefCounted> test");
-
-static_assert((std::is_same<
-    int,
     CrossThreadCopier<CopierRefCountedTest*>::Type
     >::value),
-    "Raw pointer RefCounted test");
+    "Raw pointer + RefCounted should NOT pass CrossThreadCopier");
 
 // Verify that std::unique_ptr gets passed through.
 static_assert((std::is_same<
     std::unique_ptr<float>,
     CrossThreadCopier<std::unique_ptr<float>>::Type
     >::value),
     "std::unique_ptr test");
 
 } // namespace blink