Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Issue 2103793005: [ced] Suppress a compiler warning on Windows (Closed)

Created:
4 years, 5 months ago by Jinsuk Kim
Modified:
4 years, 5 months ago
Reviewers:
tkent
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ced] Suppress a compiler warning on Windows Add a new option suppressing MSVC compiler warning: '<': signed/unsigned mismatch (/wd4018) where a signed int is used for a loop variable against unsigned int upper limit. This is a prerequisite to hooking ced to Blink. The change to gn build file was already made. This CL applies the same change to gyp. BUG=597488 Committed: https://crrev.com/0f5f22c2b38dfbbd0d4fd49146ef636b6480f86b Cr-Commit-Position: refs/heads/master@{#402728}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/ced/ced.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Jinsuk Kim
Hi tkent, could you lgtm this? The broken build https://codereview.chromium.org/2109633003 comes from the missing msvc ...
4 years, 5 months ago (2016-06-29 04:27:53 UTC) #2
tkent
lgtm
4 years, 5 months ago (2016-06-29 04:28:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103793005/1
4 years, 5 months ago (2016-06-29 04:29:15 UTC) #5
Jinsuk Kim
Thanks!
4 years, 5 months ago (2016-06-29 04:31:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 05:09:38 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 05:10:39 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f5f22c2b38dfbbd0d4fd49146ef636b6480f86b
Cr-Commit-Position: refs/heads/master@{#402728}

Powered by Google App Engine
This is Rietveld 408576698