Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2103793003: [Turbofan] Eliminate IsOutputRegisterOf and IsOutputFPRegisterOf checks. (Closed)

Created:
4 years, 5 months ago by bbudge
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Turbofan] Eliminate IsOutputRegisterOf and IsOutputFPRegisterOf checks. - Eliminates tests for whether a fixed register needs to be preserved, and conservatively adds a UsePosition for all fixed live ranges. This speeds up ProcessInstructions, especially when ARM register aliasing introduces fixed live ranges for float and SIMD 128 registers. LOG=N BUG=v8:4124 Committed: https://crrev.com/cf62923e3ba3861d34a46381fb032c01ba42fb2f Cr-Commit-Position: refs/heads/master@{#37408}

Patch Set 1 #

Patch Set 2 : Add a comment explaining why it's OK to add redundant UseIntervals. #

Patch Set 3 : Fix comment text. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -50 lines) Patch
M src/compiler/register-allocator.cc View 1 2 2 chunks +19 lines, -50 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
bbudge
This doesn't seem to slow compile time down. I think it will prevent a perf ...
4 years, 5 months ago (2016-06-29 00:14:41 UTC) #2
Benedikt Meurer
LGTM.
4 years, 5 months ago (2016-06-29 03:49:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103793003/40001
4 years, 5 months ago (2016-06-29 21:51:54 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-29 22:40:58 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 22:41:22 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cf62923e3ba3861d34a46381fb032c01ba42fb2f
Cr-Commit-Position: refs/heads/master@{#37408}

Powered by Google App Engine
This is Rietveld 408576698