Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 2103793002: [arm64] We must not overwrite registers for binop results that are used in frame states. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm64] We must not overwrite registers for binop results that are used in frame states. The ARM64 instruction selector can generate code like this negs w0, w1 b.vs deopt but then reference the old value of w0 in the frame state, which will obviously lead to wrong results. R=jarin@chromium.org BUG=v8:5158 Committed: https://crrev.com/29da5460fc5c82efea03278074fd63223997ade5 Cr-Commit-Position: refs/heads/master@{#37322}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -8 lines) Patch
M src/compiler/arm64/instruction-selector-arm64.cc View 2 chunks +17 lines, -4 lines 0 comments Download
A + test/mjsunit/compiler/regress-5158.js View 1 chunk +6 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
Benedikt Meurer
4 years, 5 months ago (2016-06-28 09:48:09 UTC) #1
Jarin
lgtm
4 years, 5 months ago (2016-06-28 09:49:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103793002/1
4 years, 5 months ago (2016-06-28 09:50:29 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 10:11:03 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 10:11:25 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/29da5460fc5c82efea03278074fd63223997ade5
Cr-Commit-Position: refs/heads/master@{#37322}

Powered by Google App Engine
This is Rietveld 408576698