Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: gpu/command_buffer/service/feature_info.cc

Issue 2103773002: Occlusion query feature is already in GL ES3.0 spec, not an extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address ken's comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/feature_info.cc
diff --git a/gpu/command_buffer/service/feature_info.cc b/gpu/command_buffer/service/feature_info.cc
index 0371fb15e5dd1d87ba7526d07c868ff6b0e16fb9..8fc1318c7bb88bedd7d6cba1824e870074e74d2f 100644
--- a/gpu/command_buffer/service/feature_info.cc
+++ b/gpu/command_buffer/service/feature_info.cc
@@ -1053,8 +1053,11 @@ void FeatureInfo::InitializeFeatures() {
extensions.Contains("GL_ARB_occlusion_query2");
bool have_arb_occlusion_query =
extensions.Contains("GL_ARB_occlusion_query");
+ bool have_es3_occlusion_query =
+ gl_version_info_->IsAtLeastGLES(3, 0);
yunchao 2016/07/04 02:22:39 This CL is used to fix crbug 623871, I think you c
xinghua.cao 2016/07/04 10:20:30 Yunchao, thanks for your comment. I still think th
- if (have_ext_occlusion_query_boolean ||
+ if (have_es3_occlusion_query ||
+ have_ext_occlusion_query_boolean ||
have_arb_occlusion_query2 ||
have_arb_occlusion_query) {
AddExtensionString("GL_EXT_occlusion_query_boolean");
Ken Russell (switch to Gerrit) 2016/06/29 22:29:56 Do we want to add this extension string if we are
xinghua.cao 2016/07/04 10:20:30 Done.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698