Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: gpu/command_buffer/service/feature_info.cc

Issue 2103773002: Occlusion query feature is already in GL ES3.0 spec, not an extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: logical error Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/feature_info.cc
diff --git a/gpu/command_buffer/service/feature_info.cc b/gpu/command_buffer/service/feature_info.cc
index 0371fb15e5dd1d87ba7526d07c868ff6b0e16fb9..c8ed4c800ed397e02d28bb7a91dc16380faf7105 100644
--- a/gpu/command_buffer/service/feature_info.cc
+++ b/gpu/command_buffer/service/feature_info.cc
@@ -1054,6 +1054,9 @@ void FeatureInfo::InitializeFeatures() {
bool have_arb_occlusion_query =
extensions.Contains("GL_ARB_occlusion_query");
xinghua.cao 2016/06/28 10:19:15 On mesa+i965 platform, supports OpenGL ES 3.1, it
+ if (IsES3Capable()) {
+ feature_flags_.occlusion_query_boolean = true;
+ }
Zhenyao Mo 2016/06/28 17:59:05 I think you need to be more careful in these setti
Ken Russell (switch to Gerrit) 2016/06/28 23:58:59 Not sure about that. Is Intel's driver OpenGL ES r
Zhenyao Mo 2016/06/29 00:39:44 My original suggestion was to always map to the ES
xinghua.cao 2016/06/29 10:40:09 It is Intel's driver OpenGL ES. I had changed it,
if (have_ext_occlusion_query_boolean ||
have_arb_occlusion_query2 ||
have_arb_occlusion_query) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698